Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/fee slider #329

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Feature/fee slider #329

wants to merge 2 commits into from

Conversation

malteish
Copy link
Collaborator

@malteish malteish commented Feb 5, 2024

See issue #328

Proposal: Enforce fee limits and compare fee amounts on per-product base instead of comparing fee types directly.
Pro:

  • simple
  • allows for fee slider in frontend
    Con:
  • complications especially with employee participation, since many fees for EP are handled off-chain. (E.g.: founder decides for 0 token fees. How do we change our cash fees to account for that?)

Copy link

Feature/fee slider

Generated at commit: 98f38de116bbe7640eb550a99709bba49724faff

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total
0
0
0
8
35
43
Dependencies Critical
High
Medium
Low
Note
Total
0
0
0
2
44
46

For more details view the full report in OpenZeppelin Code Inspector

@CJentzsch
Copy link
Collaborator

Looks good.

For EP, we have to adapt the off-chain fees when lowering the token fee. But from a smart contract perspective, this is good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants