Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/fee slider #329

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Feature/fee slider #329

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
74bff58
Merge pull request #323 from corpus-io/main
malteish Jan 5, 2024
98f38de
change fee limit handling
malteish Feb 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 15 additions & 13 deletions contracts/FeeSettings.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,12 +19,10 @@ contract FeeSettings is
IFeeSettingsV2,
IFeeSettingsV1
{
/// max token fee is 5%
uint32 public constant MAX_TOKEN_FEE_NUMERATOR = 500;
/// max crowdinvesting fee is 10%
uint32 public constant MAX_CROWDINVESTING_FEE_NUMERATOR = 1000;
/// max private offer fee is 5%
uint32 public constant MAX_PRIVATE_OFFER_FEE_NUMERATOR = 500;
/// max crowdinvesting fee (paid in token and cash combined) is 15%
uint32 public constant MAX_TOTAL_CROWDINVESTING_FEE_NUMERATOR = 1500;
/// max private offer fee (paid in token and cash combined) is 10%
uint32 public constant MAX_TOTAL_PRIVATE_OFFER_FEE_NUMERATOR = 1000;

/// Denominator to calculate all fees
uint32 public constant FEE_DENOMINATOR = 10000;
Expand Down Expand Up @@ -184,9 +182,11 @@ contract FeeSettings is

// if at least one fee increases, enforce minimum delay
if (
_fees.tokenFeeNumerator > fees[address(0)].tokenFeeNumerator ||
_fees.crowdinvestingFeeNumerator > fees[address(0)].crowdinvestingFeeNumerator ||
_fees.privateOfferFeeNumerator > fees[address(0)].privateOfferFeeNumerator
_fees.tokenFeeNumerator > fees[address(0)].tokenFeeNumerator || // token fee increases -> important for other products
_fees.crowdinvestingFeeNumerator + _fees.tokenFeeNumerator >
fees[address(0)].crowdinvestingFeeNumerator + fees[address(0)].tokenFeeNumerator || // crowdinvesting fee increases
_fees.privateOfferFeeNumerator + _fees.tokenFeeNumerator >
fees[address(0)].privateOfferFeeNumerator + fees[address(0)].tokenFeeNumerator // private offer fee increases
) {
require(
_fees.validityDate > block.timestamp + 12 weeks,
Expand Down Expand Up @@ -237,12 +237,14 @@ contract FeeSettings is
* @param _fees The fees to check
*/
function checkFeeLimits(Fees memory _fees) internal pure {
require(_fees.tokenFeeNumerator <= MAX_TOKEN_FEE_NUMERATOR, "Token fee must be <= 5%");
require(
_fees.crowdinvestingFeeNumerator <= MAX_CROWDINVESTING_FEE_NUMERATOR,
"Crowdinvesting fee must be <= 10%"
_fees.tokenFeeNumerator + _fees.crowdinvestingFeeNumerator <= MAX_TOTAL_CROWDINVESTING_FEE_NUMERATOR,
"Total Crowdinvesting fee must be <= 15%"
);
require(
_fees.tokenFeeNumerator + _fees.privateOfferFeeNumerator <= MAX_TOTAL_PRIVATE_OFFER_FEE_NUMERATOR,
"Total PrivateOffer fee must be <= 10%"
);
require(_fees.privateOfferFeeNumerator <= MAX_PRIVATE_OFFER_FEE_NUMERATOR, "PrivateOffer fee must be <= 5%");
}

/**
Expand Down
Loading