-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: minimum viable app wiring #11900
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
C:CLI
C:depinject
Issues and PR related to depinject
C:x/auth
C:x/bank
C:x/genutil
genutil module issues
C:x/nft
C:x/params
C:x/staking
labels
May 9, 2022
81 tasks
Codecov Report
@@ Coverage Diff @@
## main #11900 +/- ##
==========================================
- Coverage 66.03% 65.94% -0.10%
==========================================
Files 675 675
Lines 71283 71396 +113
==========================================
+ Hits 47073 47079 +6
- Misses 21530 21638 +108
+ Partials 2680 2679 -1
|
This was referenced May 9, 2022
@aaronc lots of these modules have their own issues, is it okay if we close this pr? |
going to close this as we are working on most of these things in other PRs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
C:CLI
C:depinject
Issues and PR related to depinject
C:x/auth
C:x/bank
C:x/genutil
genutil module issues
C:x/nft
C:x/params
C:x/staking
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ref #11899
This PR creates the minimum viable app wiring framework that can be used to:
app.go
toapp.yaml
using a hybrid approach (to be demonstrated in a separate PR)Minimum viable functionality is demonstrated by migrating the CLI tests in
x/nft
to use a standaloneapp.yaml
instead ofapp.go
.In the process, the following modules were setup with app wiring:
x/auth
x/bank
x/staking
x/genutil
x/params
x/nft
A new
cosmosdk.io/core
go module has been introduced for handling app config and registering app modules. Aruntime
package and app wiring module has been added to wrap all of the existing functionality inBaseApp
and the module manager.Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change