Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: minimum viable app wiring #11900

Closed
wants to merge 7 commits into from
Closed

feat: minimum viable app wiring #11900

wants to merge 7 commits into from

Conversation

aaronc
Copy link
Member

@aaronc aaronc commented May 9, 2022

Description

Ref #11899

This PR creates the minimum viable app wiring framework that can be used to:

  • migrate module integration tests away from simapp
  • be used to incrementally migrate app.go to app.yaml using a hybrid approach (to be demonstrated in a separate PR)

Minimum viable functionality is demonstrated by migrating the CLI tests in x/nft to use a standalone app.yaml instead of app.go.

In the process, the following modules were setup with app wiring:

  • x/auth
  • x/bank
  • x/staking
  • x/genutil
  • x/params
  • x/nft

A new cosmosdk.io/core go module has been introduced for handling app config and registering app modules. A runtime package and app wiring module has been added to wrap all of the existing functionality in BaseApp and the module manager.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@aaronc aaronc changed the title feat: app wiring MVP feat: minimum viable app wiring May 9, 2022
@codecov
Copy link

codecov bot commented May 9, 2022

Codecov Report

Merging #11900 (f69120f) into main (324da02) will decrease coverage by 0.09%.
The diff coverage is 20.35%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #11900      +/-   ##
==========================================
- Coverage   66.03%   65.94%   -0.10%     
==========================================
  Files         675      675              
  Lines       71283    71396     +113     
==========================================
+ Hits        47073    47079       +6     
- Misses      21530    21638     +108     
+ Partials     2680     2679       -1     
Impacted Files Coverage Δ
testutil/network/network.go 59.40% <0.00%> (-3.01%) ⬇️
types/module/module.go 69.49% <0.00%> (-0.60%) ⬇️
x/auth/module.go 40.62% <12.50%> (-14.07%) ⬇️
x/genutil/module.go 48.00% <25.00%> (-10.83%) ⬇️
x/bank/module.go 53.48% <28.57%> (-4.85%) ⬇️
x/params/module.go 52.38% <38.88%> (-5.40%) ⬇️
x/staking/module.go 61.72% <40.00%> (-3.07%) ⬇️
x/distribution/simulation/operations.go 80.54% <0.00%> (-9.73%) ⬇️
crypto/keys/internal/ecdsa/privkey.go 84.21% <0.00%> (+1.75%) ⬆️

@tac0turtle
Copy link
Member

@aaronc lots of these modules have their own issues, is it okay if we close this pr?

@tac0turtle
Copy link
Member

going to close this as we are working on most of these things in other PRs

@tac0turtle tac0turtle closed this Jun 7, 2022
@tac0turtle tac0turtle deleted the aaronc/app-wiring-mvp branch February 13, 2023 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants