Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add CWL PROV support #778

Merged
merged 28 commits into from
Dec 19, 2024
Merged

add CWL PROV support #778

merged 28 commits into from
Dec 19, 2024

Conversation

fmigneault
Copy link
Collaborator

@fmigneault fmigneault commented Dec 6, 2024

description

  • basic only (no extra weaver-specific tracking)

    • base /jobs/{jobId}/prov added with a few media-type variants handled
    • only return cwlprov results as is
  • needs more adjustments to apply additional weaver-specific metadata (see 'FIXME' in code changes)

  • needs further validation in a full workflow, but works for a single process call

references

endpoints preview: https://pavics-weaver--778.org.readthedocs.build/en/778/api.html#tag/Provenance

@fmigneault fmigneault self-assigned this Dec 6, 2024
@fmigneault fmigneault marked this pull request as draft December 6, 2024 07:06
@github-actions github-actions bot added ci/doc Issue related to documentation of the package feature/CWL Issue related to CWL support feature/db Related to database or datatype manipulation. feature/oas Issues related to OpenAPI specifications. process/wps3 Issue related to WPS 3.x (REST-JSON) processes support feature/job Issues related to job execution, reporting and logging. labels Dec 6, 2024
@fmigneault fmigneault added project/OGC-GDC Developments related to OGC GeoDataCube project/OGC-IPT Developments related to OGC Integrity, Provenance, and Trust WIP Work in progress labels Dec 6, 2024
@fmigneault fmigneault linked an issue Dec 7, 2024 that may be closed by this pull request
21 tasks
@github-actions github-actions bot added the ci/tests Tests of the package and features label Dec 11, 2024
@github-actions github-actions bot added the ci/operations Related to CI operations (actions, execution, install, builds, etc.) label Dec 11, 2024
@github-actions github-actions bot added the feature/cli Issues or features related to CLI operations. label Dec 13, 2024
@fmigneault fmigneault marked this pull request as ready for review December 14, 2024 00:45
@fmigneault fmigneault changed the title [wip] add CWL PROV support add CWL PROV support Dec 14, 2024
@fmigneault fmigneault removed the WIP Work in progress label Dec 14, 2024
Copy link

codecov bot commented Dec 18, 2024

Codecov Report

Attention: Patch coverage is 96.99248% with 16 lines in your changes missing coverage. Please review.

Project coverage is 87.66%. Comparing base (72d15c4) to head (e41cd24).
Report is 32 commits behind head on master.

Files with missing lines Patch % Lines
weaver/cli.py 75.60% 7 Missing and 3 partials ⚠️
weaver/provenance.py 97.12% 1 Missing and 4 partials ⚠️
weaver/processes/wps_package.py 96.15% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #778      +/-   ##
==========================================
+ Coverage   87.45%   87.66%   +0.21%     
==========================================
  Files          80       82       +2     
  Lines       20782    21257     +475     
  Branches     2832     2874      +42     
==========================================
+ Hits        18174    18636     +462     
- Misses       1862     1868       +6     
- Partials      746      753       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fmigneault fmigneault closed this Dec 19, 2024
@fmigneault fmigneault reopened this Dec 19, 2024
@fmigneault fmigneault merged commit b4e82a0 into master Dec 19, 2024
52 of 54 checks passed
@fmigneault fmigneault deleted the cwl-prov branch December 19, 2024 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/doc Issue related to documentation of the package ci/operations Related to CI operations (actions, execution, install, builds, etc.) ci/tests Tests of the package and features feature/cli Issues or features related to CLI operations. feature/CWL Issue related to CWL support feature/db Related to database or datatype manipulation. feature/job Issues related to job execution, reporting and logging. feature/oas Issues related to OpenAPI specifications. process/wps3 Issue related to WPS 3.x (REST-JSON) processes support project/OGC-GDC Developments related to OGC GeoDataCube project/OGC-IPT Developments related to OGC Integrity, Provenance, and Trust
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support CWL Prov with cwltool for OGC API - Processes IPT
1 participant