fix(kinesis): fix bug related with the use of external-name #1890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nilde
force-pushed
the
kinesis-fix-1751
branch
from
f786f43 to
b7ecb53
Compare
nilde
changed the title
MisterMX
requested changes
Oct 9, 2023
| @@ -124,7 +124,7 @@ func postCreate(_ context.Context, cr *svcapitypes.Stream, obj *svcsdk.CreateStr | |||
| if err != nil { | |||
| return managed.ExternalCreation{}, err | |||
| } | |||
| meta.SetExternalName(cr, cr.Name) | |||
| meta.SetExternalName(cr, *awsclients.String(meta.GetExternalName(cr))) | |||
There was a problem hiding this comment.
This would have no effect and just writes the value of the field into itself.
Given that in preCreate it is assumed that the external name is already set (and where it is actually needed), there is no need to set in postCreate.
I agree that using cr.Name makes no sense and is against the convention (that external name should be used). If we want to use the external name as default if external name is not set, we should use the managed.NewNameAsExternalName initializer as it is done in other places like https://github.com/crossplane-contrib/provider-aws/blob/master/pkg/controller/batch/computeenvironment/setup.go#L61.
When you have a different external-name compared to name and a bug occurres and generates 2 different streams one with the original name and other with the external name, also solves the problem related with the stream status. Signed-off-by: Domene Esteban, Nil <[email protected]> Signed-off-by: Domene Esteban, Nil {DISB~SANT CUGAT DIA} <[email protected]>
Signed-off-by: Domene Esteban, Nil {DISB~SANT CUGAT DIA} <[email protected]>
nilde
force-pushed
the
kinesis-fix-1751
branch
from
5382048 to
ab907bf
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you have a different external-name compared to name and a bug occurres and generates 2 different streams one with the original name and other with the external name, also solves the problem related with getting the correct stream status.
Signed-off-by: Domene Esteban, Nil
[email protected]
Description of your changes
Fixes #1751
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Tested locally using Localstack creating multiple Streams with different configurations.