Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use helper to centralize info about schema-supported databases #1127

Merged
merged 11 commits into from
Jul 5, 2022
Merged

chore: use helper to centralize info about schema-supported databases #1127

merged 11 commits into from
Jul 5, 2022

Conversation

maelle
Copy link
Member

@maelle maelle commented Jun 20, 2022

No description provided.

@maelle maelle requested a review from krlmlr June 20, 2022 08:08
@maelle maelle marked this pull request as ready for review June 20, 2022 08:09
@maelle maelle changed the title use helper to centralize info about schema-supported databases @maelle use helper to centralize info about schema-supported databases Jun 20, 2022
@maelle maelle mentioned this pull request Jun 20, 2022
Merged
krlmlr
krlmlr reviewed Jun 20, 2022
View reviewed changes
Copy link
Collaborator

@krlmlr krlmlr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, good idea!

NAMESPACE Outdated Show resolved Hide resolved
R/db-helpers.R Outdated Show resolved Hide resolved
tests/testthat/helper-skip.R Outdated Show resolved Hide resolved
maelle
maelle commented Jun 20, 2022
View reviewed changes
tests/testthat/helper-skip.R
@@ -23,6 +23,15 @@ skip_if_src_not <- function(...) {
}
}

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

related question #1123 (comment)

@maelle maelle requested a review from krlmlr June 20, 2022 08:30
@krlmlr
Copy link
Collaborator

krlmlr commented Jun 21, 2022

Sorry about the conflicts, should be easy to resolve though.

Base automatically changed from f-learn-mysql-2 to main June 21, 2022 05:04
krlmlr
krlmlr approved these changes Jun 21, 2022
View reviewed changes
pkgdown/_pkgdown.yml Outdated Show resolved Hide resolved
@krlmlr krlmlr changed the title use helper to centralize info about schema-supported databases chore: use helper to centralize info about schema-supported databases Jul 5, 2022
@krlmlr krlmlr merged commit 0137880 into main Jul 5, 2022
@krlmlr krlmlr deleted the f-learn-mysql-2-tweaks branch July 5, 2022 15:01
@krlmlr
Copy link
Collaborator

krlmlr commented Jul 5, 2022

Thanks!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@krlmlr krlmlr krlmlr approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maelle @krlmlr