Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: dm_from_con(learn_keys = TRUE) works for MariaDB #1123

Merged
merged 23 commits into from
Jun 21, 2022
Merged

Conversation

krlmlr
Copy link
Collaborator

@krlmlr krlmlr commented Jun 19, 2022

for relational.fit .

Closes #366. Closes #1124.

@krlmlr krlmlr force-pushed the f-learn-mysql-2 branch from 45db8a3 to d843ad9 Compare June 19, 2022 14:30
@krlmlr krlmlr force-pushed the f-learn-mysql-2 branch from d843ad9 to 7ce021b Compare June 19, 2022 14:31
@krlmlr krlmlr changed the title Implement dm_meta() for MariaDB feat: dm_from_con(learn_keys = TRUE) works for MariaDB Jun 19, 2022
@krlmlr
Copy link
Collaborator Author

krlmlr commented Jun 19, 2022

@maelle: Please feel free to add to this branch.

@maelle
Copy link
Member

maelle commented Jun 20, 2022

Noting that I do not get any failure locally but I do remember the text about MariaDB needs to be updated anyway.

@maelle
Copy link
Member

maelle commented Jun 20, 2022

Oh, actually I need to try lazy = FALSE.

R/db-helpers.R Show resolved Hide resolved
@maelle
Copy link
Member

maelle commented Jun 20, 2022

@krlmlr in the dm.Rmd vignette, do you want to

  • remove mentions of how to add primary keys
  • change the example DB to be able to demonstrate how to add primary keys?

@maelle
Copy link
Member

maelle commented Jun 20, 2022

@krlmlr should the tests that have skip_if_src_not(c("mssql", "postgres")) have been updated or do they exclude MariaDB for other reasons?

It might be nice to replace skip_if_src_not(c("mssql", "postgres")) with something more self-explanatory?

@krlmlr krlmlr merged commit 4496328 into main Jun 21, 2022
@krlmlr krlmlr deleted the f-learn-mysql-2 branch June 21, 2022 05:04
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

MariaDB supports dm_from_con(learn_keys = TRUE) dm_learn_from_db and MySQL
2 participants