Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add discussion point #9

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add discussion point #9

wants to merge 3 commits into from

Conversation

DomHudson
Copy link

I would argue that it's odd to publish code with an unfinished implementation at all. Why add the methods if you won't implement them yet?

However, if you really want to do this - why not just use the NotImplementedError? From python's docs: abstract methods should raise this exception when they require derived classes to override the method, or while the class is being developed to indicate that the real implementation still needs to be added.

It feels quite wacky to deliberately cause a syntax error when an exception also terminates the code, can contain additional context, and is used elsewhere. This approach even allows you to catch the error with a readable except NotImplementedError: statement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant