Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add discussion point #9

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add discussion point #9

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e2d4888
Add discussion point
DomHudson Sep 19, 2021
1219076
Adding comment instructions back in
DomHudson Sep 19, 2021
73c00ae
Making formatting more readable
DomHudson Sep 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions 2021/todo-abc.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,12 +122,15 @@ I concur. In the end, you're probably not even going to need that abstract base

## Discussion

No comments. Want to make a comment? Edit this page. Then submit a pull request.





> I would argue that it's odd to publish code with an unfinished implementation at all. Why add the methods if you won't implement them yet?
>
> However, if you really want to do this - why not just use the `NotImplementedError`? From [python's docs](https://docs.python.org/3/library/exceptions.html#NotImplementedError): abstract methods should raise this exception when they require derived classes to override the method, or while the class is being developed to indicate that the real implementation still needs to be added.
>
> It feels quite wacky to deliberately cause a syntax error when an exception also terminates the code, can contain additional context, and is used elsewhere. This approach even allows you to catch the error with a readable `except NotImplementedError:` statement.
>
> \- DomHudson

Want to make a comment? Edit this page. Then submit a pull request.



Expand Down