Remove nsupdate module
#1645
Remove nsupdate module
#1645
Conversation
|
DAppNode bot has built and pinned the release to an IPFS node, for commit: d5c64ca This is a development version and should only be installed for testing purposes, install link (by dappnodebot/build-action) |
| @@ -211,6 +211,7 @@ export default async function initializeDb(): Promise<void> { | |||
| // - Updates the domain: db.domain.set(domain); | |||
| dyndns.generateKeys(); // Auto-checks if keys are already generated | |||
|
|
|||
| // TODO: Move this functionality to Bind v2 package | |||
There was a problem hiding this comment.
Here we are mapping the resolution of the dyndns to the private IP, instead of the public one, to improve UX. This should be done in the bind package instead. We can leave this here only until this is implemented
| @@ -327,6 +327,9 @@ export class ComposeEditor { | |||
| !Array.isArray(service.environment) | |||
| ) | |||
| service.environment = stringifyEnvironment(service.environment); | |||
|
|
|||
| // Remove hardcoded DNS | |||
| service.dns = undefined; | |||
There was a problem hiding this comment.
We must check that this does not cause any trouble. Also, we should make sure the compose files of the packages are created without the dns instruction
| @@ -55,6 +55,7 @@ describe("modules / compose / networks", () => { | |||
| networks: { | |||
| [networkName]: { aliases }, | |||
| }, | |||
| dns: undefined, | |||
There was a problem hiding this comment.
The deep equal test requires this to be added. Is it correct?
| @@ -69,6 +70,7 @@ describe("modules / compose / networks", () => { | |||
| "sample.dnp.dappnode.eth": { | |||
| container_name, | |||
| image, | |||
| dns: undefined, | |||
|
Overwritten by #1748 |
Overrides #1588