Pin dask to 2024.1.1 #1301
Merged
Pin dask to 2024.1.1 #1301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1301 +/- ##
==========================================
+ Coverage 85.09% 85.47% +0.38%
==========================================
Files 77 77
Lines 4259 4242 -17
Branches 753 790 +37
==========================================
+ Hits 3624 3626 +2
+ Misses 466 448 -18
+ Partials 169 168 -1 ☔ View full report in Codecov by Sentry. |
charlesbluca
changed the title
|
Looks like we'll need to drop |
charlesbluca
commented
Mar 1, 2024
| @@ -26,6 +26,7 @@ dependencies: | |||
| - pytest-xdist | |||
| - pytest | |||
| - python=3.9 | |||
| - py-xgboost=1.7.0 | |||
There was a problem hiding this comment.
Noting that we'll need to make a follow-up PR to dask-build-environment as this pinning will definitely conflict with the RAPIDS xgboost.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of large Dask pinning discussions, agreed with @pentschev @rjzamora that for now it makes sense to pin dask-sql to the same Dask dependency as RAPIDS, but not to fully invest in
rapids-dask-dependency.