PHPStan linting #62
Merged
PHPStan linting #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pan93412
commented
Oct 4, 2024
pan93412
commented
- chore: Add strict rules and various plugins for PHPStan
- refactor: Optimize typing
pan93412
commented
Oct 5, 2024
Due to swc-project/swc#9609, I cannot upgrade it to the newer version :(
* Remove unused or unnecessary translation and methods * Standardize the class name (app prefix) * Mark some functions as readonly * Remove TablePrinter (use TSV instead) * Refactor UTF-8 check in Executor * Remove unnecessary comments
Note that devenv.nix is also updated to read 10-app.ini.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.