PHPStan linting

.env

@@ -29,7 +29,7 @@ APP_SECRET=
 DATABASE_URL="postgresql://app:[email protected]:5432/app?serverVersion=16&charset=utf8"
 ###< doctrine/doctrine-bundle ###
 ###> symfony/mailer ###
-# MAILER_DSN=null://null
+MAILER_DSN=null://null
 ###< symfony/mailer ###
 
 REDIS_URI=redis://redis.app-sf.orb.local:6379

.github/workflows/check.yaml

@@ -7,6 +7,10 @@ on:
 permissions:
   contents: read
 
+env:
+  # Used for PHPStan to initialize the Symfony check
+  APP_SECRET: TIRKxo3IEcWIr0x4EM6D
+
 jobs:
   lint:
     runs-on: ubuntu-latest

.gitignore

@@ -14,11 +14,6 @@
 .phpunit.result.cache
 ###< phpunit/phpunit ###
 
-###> symfony/phpunit-bridge ###
-.phpunit.result.cache
-/phpunit.xml
-###< symfony/phpunit-bridge ###
-
 ###> symfony/asset-mapper ###
 /public/assets/
 /assets/vendor/

assets/app/bootstrap.ts

@@ -1,5 +1,3 @@
 import { startStimulusApp } from "@symfony/stimulus-bundle";
 
 startStimulusApp();
-// register any custom, 3rd party controllers here
-// app.register('some_controller_name', SomeImportedController);

assets/app/index.ts

@@ -8,7 +8,7 @@ document.addEventListener("turbo:load", () => {
   const tooltipTriggerList = document.querySelectorAll("[data-bs-toggle=\"tooltip\"]");
   const tooltipList = [...tooltipTriggerList].map(tooltipTriggerEl => new bootstrap.Tooltip(tooltipTriggerEl));
 
-  // Destroy tooltips on navigating to a new page
+  // Destroy tooltips when navigating to a new page
   document.addEventListener("turbo:before-visit", () => {
     for (const tooltip of tooltipList) {
       tooltip.dispose();

assets/controllers/challenge_comment_controller.ts

@@ -11,7 +11,7 @@ export default class extends Controller<HTMLElement> {
   }
 
   async connect() {
-    const $commentBlock = this.element.querySelector(".challenge-comments__comment");
+    const $commentBlock = this.element.querySelector(".app-challenge-comment__main");
     if (!$commentBlock) {
       console.warn("No comment element found. Cannot fade in.");
       return;
@@ -22,7 +22,7 @@ export default class extends Controller<HTMLElement> {
       $commentBlock.classList.remove("opacity-0");
     }, 20 /* ms */);
 
-    const $confirmModal = this.element.querySelector<HTMLElement>(".challenge-comments__deletion_confirm");
+    const $confirmModal = this.element.querySelector<HTMLElement>(".app-challenge-comment__deletion_confirm");
     if ($confirmModal) {
       this.#modal = new bootstrap.Modal($confirmModal);
     }

assets/styles/app.scss

@@ -90,7 +90,7 @@ ul.credit {
   }
 }
 
-.question-card {
+.app-question-card {
   @extend .card;
   overflow: hidden;
   min-height: 14em;
@@ -135,7 +135,7 @@ ul.credit {
     @extend .d-flex, .gap-3, .justify-content-start, .align-items-center;
   }
 
-  .question-card__pass-rate {
+  &__pass-rate {
     &[data-pass-rate~="high"] {
       @extend .text-success;
     }
@@ -148,8 +148,7 @@ ul.credit {
   }
 }
 
-/* ChallengeHeader */
-.challenge-header {
+.app-challenge-header {
   &__title {
     font-weight: bold;
   }
@@ -184,11 +183,11 @@ ul.credit {
   }
 }
 
-.challenge-result-event-presenter {
+.app-challenge-result-event-presenter {
   table-layout: fixed;
 }
 
-.challenge-primary {
+.app-challenge-primary {
   min-height: 55vh;
 }
 
@@ -330,8 +329,8 @@ ul.credit {
   }
 }
 
-.challenge-comments {
-  &__comment {
+.app-challenge-comment {
+  &__main {
     transition: opacity 300ms;
   }
 }

composer.json

@@ -71,7 +71,8 @@
     "allow-plugins": {
       "php-http/discovery": true,
       "symfony/flex": true,
-      "symfony/runtime": true
+      "symfony/runtime": true,
+      "phpstan/extension-installer": true
     },
     "sort-packages": true
   },
@@ -129,7 +130,12 @@
   },
   "require-dev": {
     "friendsofphp/php-cs-fixer": "dev-master",
+    "phpstan/extension-installer": "1.4.x-dev",
     "phpstan/phpstan": "2.0.x-dev",
+    "phpstan/phpstan-doctrine": "2.0.x-dev",
+    "phpstan/phpstan-phpunit": "2.0.x-dev",
+    "phpstan/phpstan-strict-rules": "2.0.x-dev",
+    "phpstan/phpstan-symfony": "2.0.x-dev",
     "phpunit/phpunit": "^10",
     "symfony/browser-kit": "7.2.*",
     "symfony/css-selector": "7.2.*",