Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add multi select filter(s) #181

Merged
merged 41 commits into from
Jun 21, 2024
Merged

Add multi select filter(s) #181

merged 41 commits into from
Jun 21, 2024

Conversation

JCZuurmond
Copy link
Member

@JCZuurmond JCZuurmond commented Jun 21, 2024 •
edited
Loading

Resolves #169
Stacked on #150

See below the widgets with different number of filters and sizes:
Screenshot 2024-06-21 at 10 10 58
Screenshot 2024-06-21 at 10 08 24
Screenshot 2024-06-21 at 10 08 43
Screenshot 2024-06-21 at 10 09 13

@JCZuurmond JCZuurmond requested a review from nfx June 21, 2024 08:11
@JCZuurmond JCZuurmond self-assigned this Jun 21, 2024
@JCZuurmond JCZuurmond mentioned this pull request Jun 21, 2024
Closed
@JCZuurmond JCZuurmond changed the base branch from main to feat/dashboard-as-code-for-ucx June 21, 2024 08:12
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 21, 2024 •
edited
Loading

✅ 33/33 passed, 3 flaky, 2 skipped, 8m30s total

Flaky tests:

  • 🤪 test_dashboard_deploys_dashboard_with_table (21.479s)
  • 🤪 test_dashboards_deploys_dashboard_with_order_overwrite (22.267s)
  • 🤪 test_dashboard_deploys_dashboard_with_display_name (27.567s)

Running from acceptance #222

JCZuurmond added 23 commits June 21, 2024 12:53
@JCZuurmond
Add integration test for query with filter
97bbe2e
@JCZuurmond
Refactor to get layouts from tile
fdb0d3f
@JCZuurmond
Restructure QueryTile methods
111da24
@JCZuurmond
Rename WidgetMetadata to TileMetadata
dd6c35e
@JCZuurmond
Refactor get dataset to get_datasets
3e7db3c
@JCZuurmond
Rename _get_spec to _get_query_widget_spec
9d9593d
@JCZuurmond
Split get layouts into query and filter layouts
f7cf8ca
@JCZuurmond
Add docs
236e30d
@JCZuurmond
Add filter to header
2194fa9
@JCZuurmond
Change for multiple filters
ba6edfa
@JCZuurmond
Add MultiSelectFilter
36f7bbf
@JCZuurmond
missing nargs to add_argument
78b2163
@JCZuurmond
Handle widget size if filter is present
adc599b
@JCZuurmond
Raise value error when there are too many filters defined
cb13d01
@JCZuurmond
Position many filters
a773db0
@JCZuurmond
Readjust y of query widget
710b477
@JCZuurmond
Add docs
1309b26
@JCZuurmond
Let all filter widgets have a unique name
bbd8330
@JCZuurmond
Fix typo's
8400ac6
@JCZuurmond
Test and fix with one row of many filters
18bad89
@JCZuurmond
Harden filter tiling logic
9553597
@JCZuurmond
Invert bottom row spacing
ff88a7b
@JCZuurmond
Change wording in comment
dce76fa
@JCZuurmond JCZuurmond force-pushed the feat/add-multi-select-filter-2 branch from 817a34b to ffb3307 Compare June 21, 2024 10:53
nfx
nfx approved these changes Jun 21, 2024
View reviewed changes
Copy link
Collaborator

@nfx nfx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@nfx nfx merged commit aa2f325 into feat/dashboard-as-code-for-ucx Jun 21, 2024
9 of 10 checks passed
@nfx nfx deleted the feat/add-multi-select-filter-2 branch June 21, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nfx nfx nfx approved these changes

Assignees

@JCZuurmond JCZuurmond

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] Filter dashboard widgets using multiple select
2 participants
@JCZuurmond @nfx