Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(airflow): drop Airflow < 2.3 support + make plugin v2 the default #12056

Merged
merged 8 commits into from
Dec 9, 2024

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Dec 6, 2024

Why is it ok to drop Airflow < 2.3?

Why do we want to do this?
This will let us make the DataHub plugin v2 the default version. Specifically, the v2 plugin dependencies will be part of the base requirements and not an extra. This should significantly increase the v2 plugin adoption, and is pretty safe since we already have tons of folks using it successfully in prod - based on both telemetry and anecdotal evidence.

For now the v1 plugin remains, and can be activated by setting the DATAHUB_AIRFLOW_PLUGIN_USE_V1_PLUGIN=true env variable. However, the goal is to drop the v1 plugin in the future.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added ingestion PR or Issue related to the ingestion of metadata docs Issues and Improvements to docs devops PR or Issue related to DataHub backend & deployment labels Dec 6, 2024
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Dec 7, 2024
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[actionlint] reported by reviewdog 🐶
the runner of "actions/upload-artifact@v3" action is too old to run on GitHub Actions. update the action's version to fix this issue [action]

- uses: actions/upload-artifact@v3

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[actionlint] reported by reviewdog 🐶
the runner of "codecov/codecov-action@v3" action is too old to run on GitHub Actions. update the action's version to fix this issue [action]

uses: codecov/codecov-action@v3

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[actionlint] reported by reviewdog 🐶
the runner of "actions/upload-artifact@v3" action is too old to run on GitHub Actions. update the action's version to fix this issue [action]

uses: actions/upload-artifact@v3

@datahub-cyborg datahub-cyborg bot added pending-submitter-merge and removed needs-review Label for PRs that need review from a maintainer. labels Dec 7, 2024
@hsheth2 hsheth2 added release-0.15.0 merge-pending-ci A PR that has passed review and should be merged once CI is green. and removed pending-submitter-merge labels Dec 9, 2024
@hsheth2 hsheth2 merged commit 2babbe6 into master Dec 9, 2024
97 of 100 checks passed
@hsheth2 hsheth2 deleted the airflow-plugin-v2-default branch December 9, 2024 19:08
hsheth2 added a commit that referenced this pull request Dec 27, 2024
This was initially added in
#7313 and then reverted
in #7490. Now that we've
dropped support for old Airflow versions in
#12056, we can actually
do the upgrade.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops PR or Issue related to DataHub backend & deployment docs Issues and Improvements to docs ingestion PR or Issue related to the ingestion of metadata merge-pending-ci A PR that has passed review and should be merged once CI is green. release-0.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants