-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(airflow): drop Airflow < 2.3 support + make plugin v2 the default #12056
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[actionlint] reported by reviewdog 🐶
the runner of "actions/upload-artifact@v3" action is too old to run on GitHub Actions. update the action's version to fix this issue [action]
- uses: actions/upload-artifact@v3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[actionlint] reported by reviewdog 🐶
the runner of "codecov/codecov-action@v3" action is too old to run on GitHub Actions. update the action's version to fix this issue [action]
uses: codecov/codecov-action@v3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[actionlint] reported by reviewdog 🐶
the runner of "actions/upload-artifact@v3" action is too old to run on GitHub Actions. update the action's version to fix this issue [action]
uses: actions/upload-artifact@v3 |
Why is it ok to drop Airflow < 2.3?
Why do we want to do this?
This will let us make the DataHub plugin v2 the default version. Specifically, the v2 plugin dependencies will be part of the base requirements and not an extra. This should significantly increase the v2 plugin adoption, and is pretty safe since we already have tons of folks using it successfully in prod - based on both telemetry and anecdotal evidence.
For now the v1 plugin remains, and can be activated by setting the
DATAHUB_AIRFLOW_PLUGIN_USE_V1_PLUGIN=true
env variable. However, the goal is to drop the v1 plugin in the future.Checklist