Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce memory footprint of state messages #212

Merged
merged 2 commits into from
Apr 16, 2022

Conversation

laurentS
Copy link
Collaborator

PR copied from oviohub#2

This PR helps substantially reduce the memory footprint of the target by storing the singer STATE message in their raw string format instead of the deserialized objects.

The downside is that STATE messages are deserialized twice instead of just one time, so there is some slight performance penalty. However, this only really applies to 1/N such messages, with N depending on the max__batch_rows config setting, but typically appearing to be >100.

In practice, we've seen a memory footprint reduction by a factor of 15-20x with this change, this will of course depend on how your STATE messages are structured.

@ericboucher ericboucher changed the title Reduce memory footprint due to storing state messages Reduce memory footprint of state messages Apr 16, 2022
@ericboucher ericboucher merged commit af4856b into datamill-co:master Apr 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants