Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce memory footprint of state messages #212

Merged
merged 2 commits into from
Apr 16, 2022
Merged

Reduce memory footprint of state messages #212

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5c0e666
Reduce memory footprint due to storing state messages
laurentS Feb 8, 2022
2b76852
Merge branch 'master' into pr/212
ericboucher Apr 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions target_postgres/stream_tracker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,9 +48,9 @@ def flush_streams(self, force=False):

self._emit_safe_queued_states(force=force)

def handle_state_message(self, line_data):
def handle_state_message(self, line):
if self.emit_states:
self.state_queue.append({'state': line_data['value'], 'watermark': self.message_counter})
self.state_queue.append({'state': line, 'watermark': self.message_counter})
self._emit_safe_queued_states()

def handle_record_message(self, stream, line_data):
Expand Down Expand Up @@ -80,9 +80,14 @@ def _emit_safe_queued_states(self, force=False):
valid_flush_watermarks.append(watermark)
safe_flush_threshold = min(valid_flush_watermarks, default=0)

# the STATE message that the target forwards
emittable_state = None
emittable_state_str = None
while len(self.state_queue) > 0 and (force or self.state_queue[0]['watermark'] <= safe_flush_threshold):
emittable_state = self.state_queue.popleft()['state']
emittable_state_str = self.state_queue.popleft()['state']

if emittable_state_str is not None:
emittable_state = json.loads(emittable_state_str)['value']

if emittable_state:
if len(statediff.diff(emittable_state, self.last_emitted_state or {})) > 0:
Expand Down
3 changes: 2 additions & 1 deletion target_postgres/target_tools.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,8 @@ def _line_handler(state_tracker, target, invalid_records_detect, invalid_records
state_tracker.flush_stream(line_data['stream'])
target.activate_version(stream_buffer, line_data['version'])
elif line_data['type'] == 'STATE':
state_tracker.handle_state_message(line_data)
# pass the string instead of the deserialized object to save memory in the deque
state_tracker.handle_state_message(line)
else:
raise TargetError('Unknown message type {} in message {}'.format(
line_data['type'],
Expand Down