Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GA of Keep on latest version #5214

Merged
merged 61 commits into from
May 2, 2024
Merged

GA of Keep on latest version #5214

merged 61 commits into from
May 2, 2024

Conversation

nghi-ly
Copy link
Contributor

@nghi-ly nghi-ly commented Apr 2, 2024

What are you changing in this pull request and why?

GA release of Keep on latest version setting

  • Removed mentions of "Public Preview"
  • Release note

Checklist

@nghi-ly nghi-ly requested a review from a team as a code owner April 2, 2024 21:58
Copy link

vercel bot commented Apr 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 2, 2024 9:43pm

@nghi-ly nghi-ly requested review from jtcohen6 and removed request for a team April 2, 2024 21:58
@github-actions github-actions bot added content Improvements or additions to content guides Knowledge best suited for Guides size: small This change will take 1 to 2 days to address Docs team Authored by the Docs team @dbt Labs labels Apr 2, 2024

dbt Labs is committed to zero breaking changes for code in dbt projects, with ongoing releases to dbt Cloud and new versions of dbt Core. We also recommend these best practices:

- **If you install dbt packages** — for use in your project, whether the package is maintained by your colleagues or a member of the open source dbt community, we recommend pinning the package to a specific revision or `version` boundary. Since v1.7, dbt manages this out-of-the-box by _locking_ the version/revision of packages in development in order to guarantee predictable builds in production. To learn more, refer to [Predictable package installs](/reference/commands/deps#predictable-package-installs).
- **If you maintain dbt packages** — whether on behalf of your colleagues or members of the open source community, we recommend writing defensive code that checks to verify that other required packages and global macros are available. For example, if your package depends on the availability of a `date_spine` macro in the global `dbt` namespace, you can write:
<expandable alt_header="Installing dbt packages" >
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

used new MD component to help reduce the callout size

Copy link
Contributor

@mirnawong1 mirnawong1 May 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fyi @nghi-ly i think the expandable isn't liking the callout. its hard to read in dark mode (maybe detailsToggle might work?):

Screenshot 2024-05-02 at 17 29 46

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, great catch!

per our chat, i'll go ahead and leave this as is since it sounds like the expandable update will get merged tomorrow.

@nghi-ly nghi-ly requested a review from jtcohen6 May 1, 2024 21:46
@@ -144,7 +144,7 @@ The most common data environments are production, staging, and development. The
1. **Set up development environment** &mdash; Set up your [development](/docs/dbt-cloud-environments#create-a-development-environment) environment and [development credentials](/docs/cloud/dbt-cloud-ide/develop-in-the-cloud#access-the-cloud-ide). You’ll need this to access your dbt project and start developing.

2. **dbt Core version** &mdash; In your dbt Cloud environment and credentials, use the same dbt Core version you use locally. You can run `dbt --version` in the command line to find out which version of dbt Core you’re using.
- When using dbt Core, you need to think about which version you’re using and manage your own upgrades. When using dbt Cloud, leverage [Keep on latest version](/docs/dbt-versions/upgrade-dbt-version-in-cloud#keep-on-latest-version-) so you don’t have to.
- When using dbt Core, you need to think about which version you’re using and manage your own upgrades. When using dbt Cloud, leverage [Keep on latest version](/docs/dbt-versions/upgrade-dbt-version-in-cloud#keep-on-latest-version) so you don’t have to.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@github-actions github-actions bot added size: medium This change will take up to a week to address and removed size: small This change will take 1 to 2 days to address labels May 2, 2024
@nghi-ly nghi-ly requested a review from jtcohen6 May 2, 2024 16:00
Copy link
Collaborator

@jtcohen6 jtcohen6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one suggestion, otherwise lgtm !

website/docs/docs/dbt-versions/2024-release-notes.md Outdated Show resolved Hide resolved
@nghi-ly nghi-ly enabled auto-merge May 2, 2024 21:36
@nghi-ly nghi-ly merged commit 27a69bf into current May 2, 2024
11 checks passed
@nghi-ly nghi-ly deleted the ly-docs-keep-latest-ga branch May 2, 2024 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto update content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs guides Knowledge best suited for Guides size: medium This change will take up to a week to address
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants