Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GA of Keep on latest version #5214
GA of Keep on latest version #5214
Changes from 53 commits
bcd1b1b
30d404f
0418939
fd758a1
a4b54e9
20af173
56ac0e9
0ecb064
59db5c0
d6df6cb
a5c03a4
97e93c1
2d8ce6f
74782da
4d314af
aa2b255
84a5be0
f8772ec
82b117b
4afbda6
c408b82
3df434a
a4dda95
8e9576f
14ca454
ae647b8
04fd270
eacf21f
aacebb9
2d6d46b
dcae369
7d3fe79
3fa03f1
8bab8c5
7cb873d
497c2b0
2d0576a
6258398
7c741f1
a07a488
b903b20
f773d8d
a30f022
b97693a
baa6fd7
a7434f1
ed51386
c033191
68bd63c
601325c
1e30ee3
708783d
5f9d656
f5620b2
0571564
9beb724
0c1fc09
b97b461
93e91af
f7a56e9
efa7133
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
used new MD component to help reduce the callout size
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fyi @nghi-ly i think the expandable isn't liking the callout. its hard to read in dark mode (maybe
detailsToggle
might work?):There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, great catch!
per our chat, i'll go ahead and leave this as is since it sounds like the
expandable
update will get merged tomorrow.