Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add pull request template #1335

Merged
merged 4 commits into from
Oct 30, 2023
Merged

Conversation

andyesp
Copy link
Member

@andyesp andyesp commented Oct 10, 2023

Closes #1375

@andyesp andyesp marked this pull request as draft October 10, 2023 19:06
Copy link
Collaborator

@1emu 1emu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this checklist.

I would also add the following:

- [ ] **Security**
    - [ ] No sensitive data hardcoded
    - [ ] Proper input validation and sanitation (check routes and db queries)
    - [ ] Auth checks for new endpoints
- [ ] **Performance**
    - [ ] No N+1 queries
    - [ ] Proper use of caching/stale times
- [ ] **Rollback Plan**
    - [ ] Database migrations are reversible
    - [ ] Feature flags used for risky changes
- [ ] **Documentation**
    - [ ] README updated
    - [ ] Public API changes are documented (remove this one from Functionality Validation)
- [ ] **Accessibility**
    - [ ] UI changes are accessible, i.e., screen reader tests, Guane's magic check

Also, one important thing we are missing and we should add to one of this sections is the mobile view of any new page/component we add.
That could also be added to the Issue/Feature Checklist

.github/pull_request_template.md Outdated Show resolved Hide resolved
.github/pull_request_template.md Outdated Show resolved Hide resolved
.github/pull_request_template.md Outdated Show resolved Hide resolved
.github/pull_request_template.md Show resolved Hide resolved
.github/pull_request_template.md Show resolved Hide resolved
@andyesp andyesp marked this pull request as ready for review October 27, 2023 15:00
@andyesp andyesp merged commit 6d7b20a into master Oct 30, 2023
1 check passed
@andyesp andyesp deleted the chore/add-pull-request-template branch October 30, 2023 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add pull request template to repository
4 participants