Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add pull request template #1335

Merged
merged 4 commits into from
Oct 30, 2023
Merged

chore: add pull request template #1335

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6ea6c80
chore: add pull request template
andyesp Oct 10, 2023
f5bf83a
chore: update pull request template
andyesp Oct 19, 2023
b975883
chore: update texts
andyesp Oct 27, 2023
3cb12dc
chore: update texts
andyesp Oct 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions .github/pull_request_template.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
**Screenshots**

**Related Issue**
E.g: *Closes/Fixes #1234*

- [ ] **Code Quality**
- [ ] The code follows established coding standards and style guidelines
ginocingolani marked this conversation as resolved.
Show resolved Hide resolved
- [ ] The code is properly commented on and provides context when needed (complex feature or hard to understand)
- [ ] **Functionality validation**
- [ ] Feature working as described in the related issue
- [ ] Does this PR need environment variables to be set? If yes, have they been set?
1emu marked this conversation as resolved.
Show resolved Hide resolved
- [ ] New API endpoints are properly documented
- [ ] New functions are properly tested (When should we add tests?)
ginocingolani marked this conversation as resolved.
Show resolved Hide resolved
- [ ] Code errors are being logged in the code health service
- [ ] **Product validation**
- [ ] UI changes look the same as in Figma
- [ ] Usage events are being sent to the product analytics service
ginocingolani marked this conversation as resolved.
Show resolved Hide resolved
- [ ] New common components have been documented in Storybook
ginocingolani marked this conversation as resolved.
Show resolved Hide resolved
- [ ] Preview link if it’s a customer facing issue
Loading