Update dependencies #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have marked this as a draft because, while I've tested the code locally with |
wjt
added a commit
to endlessm/godot-block-coding
that referenced
this pull request
Jun 28, 2024
The referenced commit is the merge of these two PRs: deep-entertainment/godot-asset-lib-action#2 deep-entertainment/godot-asset-lib-action#3 https://phabricator.endlessm.com/T35503
wjt
force-pushed
the
update-dependencies
branch
2 times, most recently
from
5351cd4 to
be147e1
Compare
|
It was surprising to me to find that the generated code is checked into the repository. (But Node is not my usual toolchain.) I opted to update |
wjt
added a commit
to endlessm/godot-block-coding
that referenced
this pull request
Jun 28, 2024
The referenced commit is the merge of these two PRs: deep-entertainment/godot-asset-lib-action#2 deep-entertainment/godot-asset-lib-action#3 https://phabricator.endlessm.com/T35503
wjt
added a commit
to endlessm/godot-block-coding
that referenced
this pull request
Jul 2, 2024
I realised that the previous pinned commit had not refreshed dist/index.js for some of the changes. This pinned commit corresponds to <deep-entertainment/godot-asset-lib-action#3>.
|
I have successfully published a new release of our plugin using this branch. |
|
@wjt I've merged the other PRs now. Is this still required? I was confused by all the PRs. 😄 |
|
It's still desirable. I'll rebase this to fix conflicts and ping you when ready. |
This is just the result of running:
npm update
In particular, this updates @actions/core to a version new enough to use
environment files for output rather than stdout. Without this, the
following method call:
core.setOutput('id', assetEditId)
results in the following warning:
> Warning: The `set-output` command is deprecated and will be disabled
> soon. Please upgrade to using Environment Files. For more information
> see:
> https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
This addresses a warning that the previously-pinned version was affected by GHSA-wf5p-g6vw-rhxx.
This fixes the following warning issued by node.js due to one of the
package's transitive dependencies:
(node:243) [DEP0040] DeprecationWarning: The `punycode` module is deprecated. Please use a userland alternative instead.
at node:punycode:3:9
at BuiltinModule.compileForInternalLoader (node:internal/bootstrap/realm:398:7)
at BuiltinModule.compileForPublicLoader (node:internal/bootstrap/realm:337:10)
at loadBuiltinModule (node:internal/modules/helpers:96:7)
at Module._load (node:internal/modules/cjs/loader:1063:17)
at wrapModuleLoad (node:internal/modules/cjs/loader:212:19)
at Module.require (node:internal/modules/cjs/loader:1297:12)
at require (node:internal/modules/helpers:123:16)
at Object.<anonymous> (/sysroot/home/wjt/src/deep-entertainment/godot-asset-lib-action/node_modules/whatwg-url/lib/url-state-machine.js:2:18)
at Module._compile (node:internal/modules/cjs/loader:1460:14)
node12 is no longer supported by GitHub Actions; since summer 2023 actions have been run against node16 instead. node20 is the latest supported version. Run both the action, and the workflow which checks that the generated code is up to date, against node20. https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/
|
This one is ready to go now. As described it updates the Node.JS runtime that the action uses, and also updates all the action's dependencies to their latest releases. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
npm outdatedshows the following:npm auditshows:@actions/coreis pinned to an old minor version, causing a warning to be logged on each run:And
actions.ymlspecifies thenode12runtime, which has been unsupported since summer 2023: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/.This PR updates all dependencies to their latest versions (including new semver major versions); and updates the actions runtime to
node20.Stacked on: