Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: check task config policies against slots and max_slots #10015

Merged
merged 3 commits into from
Oct 3, 2024

fix error messaging

84b8d29
Select commit
Loading
Failed to load commit list.
Merged

chore: check task config policies against slots and max_slots #10015

fix error messaging
84b8d29
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 3, 2024 in 0s

54.57% (-0.02%) compared to 1297899

View this Pull Request on Codecov

54.57% (-0.02%) compared to 1297899

Details

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 54.57%. Comparing base (1297899) to head (84b8d29).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
master/internal/api_command.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10015      +/-   ##
==========================================
- Coverage   54.58%   54.57%   -0.02%     
==========================================
  Files        1259     1259              
  Lines      157233   157236       +3     
  Branches     3619     3619              
==========================================
- Hits        85831    85816      -15     
- Misses      71269    71287      +18     
  Partials      133      133              
Files with missing lines Coverage Δ
master/internal/configpolicy/task_config_policy.go 84.78% <100.00%> (+1.06%) ⬆️
master/internal/api_command.go 47.88% <0.00%> (ø)

... and 10 files with indirect coverage changes