feat: add metadata column type badge #10052

thiagodallacqua-hpe · 2024-10-14T19:36:44Z

Ticket

Description

Right now, if we have multiple metadata columns with the same name, there's no quick way of knowing of which type each one is while selecting it. This PR intends to add a descriptive badge next to duplicate entries for the metadata columns.

Test Plan

make sure that you have at least one metadata column that is duplicated and of a different type
go to a experiment list
- make sure that the grid visualization is enabled
open the column picker
verify that the duplicates has a <column_name> <column_type_tag> format

Checklist

Changes have been manually QA'd
New features have been approved by the corresponding PM
User-facing API changes have the "User-facing API Change" label
Release notes have been added as a separate file under docs/release-notes/
See Release Note for details.
Licenses have been included for new code which was copied and/or modified from any external code

netlify · 2024-10-14T19:37:02Z

✅ Deploy Preview for determined-ui ready!

Name	Link
🔨 Latest commit	`cbf0bb1`
🔍 Latest deploy log	https://app.netlify.com/sites/determined-ui/deploys/672a42e0a84e2600085acf34
😎 Deploy Preview	https://deploy-preview-10052--determined-ui.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

codecov · 2024-10-14T19:38:58Z

Codecov Report

Attention: Patch coverage is 68.47826% with 29 lines in your changes missing coverage. Please review.

Project coverage is 54.07%. Comparing base (225848a) to head (c801b0c).

❗ Current head c801b0c differs from pull request most recent head cbf0bb1

Please upload reports for the commit cbf0bb1 to get more accurate results.

Files with missing lines	Patch %	Lines
webui/react/src/pages/FlatRuns/FlatRuns.tsx	3.84%	25 Missing ⚠️
webui/react/src/components/ColumnPickerMenu.tsx	92.15%	3 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #10052      +/-   ##
==========================================
- Coverage   54.35%   54.07%   -0.28%     
==========================================
  Files        1259      448     -811     
  Lines      157337    77346   -79991     
  Branches     3644     3654      +10     
==========================================
- Hits        85517    41827   -43690     
+ Misses      71687    35385   -36302     
- Partials      133      134       +1

Flag	Coverage Δ
harness	`?`
web	`54.33% <68.47%> (+0.02%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
webui/react/src/components/Searches/columns.ts	`51.38% <ø> (-0.51%)`	⬇️
webui/react/src/pages/F_ExpList/expListColumns.ts	`21.23% <ø> (+0.29%)`	⬆️
webui/react/src/pages/FlatRuns/columns.ts	`18.69% <ø> (+0.20%)`	⬆️
webui/react/src/utils/flatRun.ts	`99.24% <100.00%> (+0.08%)`	⬆️
webui/react/src/components/ColumnPickerMenu.tsx	`96.01% <92.15%> (+0.08%)`	⬆️
webui/react/src/pages/FlatRuns/FlatRuns.tsx	`11.27% <3.84%> (+0.05%)`	⬆️

... and 815 files with indirect coverage changes

keita-determined

we wanna show types for all columns.
and keys need to be adjusted.

keita-determined · 2024-10-18T19:22:48Z

can we prioritize this PR over the PR about filter #10046?

webui/react/src/components/ColumnPickerMenu.tsx

keita-determined

Could you make sure this PR displays the columns' data correctly on #10066?
so far, it doesnt show data correctly.

webui/react/src/components/ColumnPickerMenu.tsx

keita-determined · 2024-10-22T19:19:43Z

webui/react/src/components/ColumnPickerMenu.tsx

@@ -63,6 +66,12 @@ interface ColumnTabProps {
  onHeatmapSelectionRemove?: (id: string) => void;
 }

+export const formatColumnKey = (col: ProjectColumn): string => {


i think we wanna store all columns with types based on the discussion 2 weeks ago.

this is basically used for mapping and encoding the UI part, which seems only necessary for the arbitrary metadata columns, as discussed with @ashtonG previously 😅

just confirming -- as the only affected columns are run metadata columns, we should be okay to limit the type encoding to run metadata columns.

As far as i know, hyperparameter would have the same names with different types too. i think its safer to encode all columns for the future and consistency.

ashtonG

found a bug -- with multiple types of the same metadata column selected, changing the column width of one column changes the width of all columns with the same name. please make sure the column ids that we're sending to the datagrid component are correct.

webui/react/src/components/ColumnPickerMenu.tsx

thiagodallacqua-hpe · 2024-10-24T15:48:57Z

webui/react/src/components/ColumnPickerMenu.tsx

+        KNOWN_BOOLEAN_COLUMNS.includes(col.column) && col.type === V1ColumnType.UNSPECIFIED
+          ? 'BOOLEAN'
+          : removeColumnTypePrefix(col.type);


it turns out that col.column in runColumns returns false even if the column is actually part of it 😅

but, this works

webui/react/src/components/ColumnPickerMenu.tsx

webui/react/src/components/Searches/Searches.tsx

webui/react/src/utils/flatRun.ts

webui/react/package-lock.json

thiagodallacqua-hpe · 2024-11-05T16:21:20Z

Closing PR due to company restructuring.

thiagodallacqua-hpe requested a review from a team as a code owner October 14, 2024 19:36

thiagodallacqua-hpe requested a review from keita-determined October 14, 2024 19:36

cla-bot bot added the cla-signed label Oct 14, 2024

thiagodallacqua-hpe requested review from ashtonG and removed request for keita-determined October 14, 2024 19:38

thiagodallacqua-hpe assigned ashtonG Oct 14, 2024

keita-determined suggested changes Oct 14, 2024

View reviewed changes

thiagodallacqua-hpe force-pushed the thiago/ET-791 branch from ef0ce65 to 2b673bb Compare October 18, 2024 20:50

thiagodallacqua-hpe requested a review from keita-determined October 18, 2024 20:51

thiagodallacqua-hpe force-pushed the thiago/ET-791 branch from 2b673bb to 22529d6 Compare October 18, 2024 22:52

thiagodallacqua-hpe assigned keita-determined Oct 18, 2024

thiagodallacqua-hpe force-pushed the thiago/ET-791 branch from dff0977 to d6ce663 Compare October 21, 2024 16:46

ashtonG suggested changes Oct 21, 2024

View reviewed changes

webui/react/src/components/ColumnPickerMenu.tsx Outdated Show resolved Hide resolved

webui/react/src/components/ColumnPickerMenu.tsx Outdated Show resolved Hide resolved

thiagodallacqua-hpe force-pushed the thiago/ET-791 branch 3 times, most recently from c3b4786 to 6fde852 Compare October 22, 2024 16:08

thiagodallacqua-hpe requested a review from ashtonG October 22, 2024 17:09

thiagodallacqua-hpe force-pushed the thiago/ET-791 branch from 6fde852 to d9d0f52 Compare October 22, 2024 17:14

keita-determined suggested changes Oct 22, 2024

View reviewed changes

thiagodallacqua-hpe force-pushed the thiago/ET-791 branch 2 times, most recently from 1a7b2bf to 1d1ddd1 Compare October 23, 2024 14:00

thiagodallacqua-hpe requested review from a team as code owners October 23, 2024 16:51

thiagodallacqua-hpe requested a review from jgongd October 23, 2024 16:51

ashtonG suggested changes Oct 23, 2024

View reviewed changes

thiagodallacqua-hpe requested review from ashtonG and removed request for jgongd October 23, 2024 17:21

thiagodallacqua-hpe force-pushed the thiago/ET-791 branch 4 times, most recently from 78dda83 to 5ddcc36 Compare October 23, 2024 19:29

ashtonG reviewed Oct 23, 2024

View reviewed changes

webui/react/src/components/ColumnPickerMenu.tsx Outdated Show resolved Hide resolved

thiagodallacqua-hpe force-pushed the thiago/ET-791 branch 2 times, most recently from 8eba48a to f6c896e Compare October 24, 2024 14:49

thiagodallacqua-hpe commented Oct 24, 2024

View reviewed changes

ashtonG reviewed Oct 24, 2024

View reviewed changes

thiagodallacqua-hpe force-pushed the thiago/ET-791 branch from 1009ae7 to ccac19c Compare October 24, 2024 17:37

thiagodallacqua-hpe requested review from keita-determined and ashtonG October 28, 2024 16:08

keita-determined reviewed Oct 29, 2024

View reviewed changes

webui/react/package-lock.json Outdated Show resolved Hide resolved

thiagodallacqua-hpe force-pushed the thiago/ET-791 branch 4 times, most recently from f4aa269 to c801b0c Compare October 31, 2024 14:38

thiagodallacqua-hpe requested a review from keita-determined October 31, 2024 14:55

thiagodallacqua-hpe force-pushed the thiago/ET-791 branch 3 times, most recently from 0a4e9c2 to 9ddcc0e Compare November 1, 2024 17:18

feat: add metadata column type badge

cbf0bb1

thiagodallacqua-hpe force-pushed the thiago/ET-791 branch from 9ddcc0e to cbf0bb1 Compare November 5, 2024 16:07

thiagodallacqua-hpe closed this Nov 5, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add metadata column type badge #10052

feat: add metadata column type badge #10052

thiagodallacqua-hpe commented Oct 14, 2024 •

edited

Loading

netlify bot commented Oct 14, 2024 •

edited

Loading

codecov bot commented Oct 14, 2024 •

edited

Loading

keita-determined left a comment

keita-determined commented Oct 18, 2024 •

edited

Loading

keita-determined left a comment

keita-determined Oct 22, 2024

thiagodallacqua-hpe Oct 23, 2024

ashtonG Oct 23, 2024

keita-determined Oct 29, 2024

ashtonG left a comment

thiagodallacqua-hpe Oct 24, 2024

thiagodallacqua-hpe commented Nov 5, 2024

feat: add metadata column type badge #10052

feat: add metadata column type badge #10052

Conversation

thiagodallacqua-hpe commented Oct 14, 2024 • edited Loading

Ticket

Description

Test Plan

Checklist

netlify bot commented Oct 14, 2024 • edited Loading

✅ Deploy Preview for determined-ui ready!

codecov bot commented Oct 14, 2024 • edited Loading

Codecov Report

keita-determined left a comment

Choose a reason for hiding this comment

keita-determined commented Oct 18, 2024 • edited Loading

keita-determined left a comment

Choose a reason for hiding this comment

keita-determined Oct 22, 2024

Choose a reason for hiding this comment

thiagodallacqua-hpe Oct 23, 2024

Choose a reason for hiding this comment

ashtonG Oct 23, 2024

Choose a reason for hiding this comment

keita-determined Oct 29, 2024

Choose a reason for hiding this comment

ashtonG left a comment

Choose a reason for hiding this comment

thiagodallacqua-hpe Oct 24, 2024

Choose a reason for hiding this comment

thiagodallacqua-hpe commented Nov 5, 2024

thiagodallacqua-hpe commented Oct 14, 2024 •

edited

Loading

netlify bot commented Oct 14, 2024 •

edited

Loading

codecov bot commented Oct 14, 2024 •

edited

Loading

keita-determined commented Oct 18, 2024 •

edited

Loading