Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support multi-type columns in flat run table #10066

Closed
wants to merge 2 commits into from

Conversation

keita-determined
Copy link
Contributor

@keita-determined keita-determined commented Oct 16, 2024

Ticket

ET-792

Description

  • Support multi-type columns in flat run table in case there are the same column names with different types.
image

Test Plan

  • Add columns from column picker, and columns show the right data even if there are the same column name like metadata.
  • Column header shows its types.
    • some special columns does not show types since types are unknown

Checklist

  • Changes have been manually QA'd
  • New features have been approved by the corresponding PM
  • User-facing API changes have the "User-facing API Change" label
  • Release notes have been added as a separate file under docs/release-notes/
    See Release Note for details.
  • Licenses have been included for new code which was copied and/or modified from any external code

@cla-bot cla-bot bot added the cla-signed label Oct 16, 2024
Copy link

netlify bot commented Oct 16, 2024

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit 4e3c1c6
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/6717fcfded911f0008f8fd03
😎 Deploy Preview https://deploy-preview-10066--determined-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Oct 17, 2024

Codecov Report

Attention: Patch coverage is 24.00000% with 38 lines in your changes missing coverage. Please review.

Project coverage is 50.46%. Comparing base (c6c476c) to head (4e3c1c6).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
webui/react/src/pages/FlatRuns/FlatRuns.tsx 5.55% 17 Missing ⚠️
webui/react/src/pages/FlatRuns/columns.ts 0.00% 12 Missing ⚠️
webui/react/src/pages/F_ExpList/expListColumns.ts 0.00% 6 Missing ⚠️
webui/react/src/utils/flatRun.ts 75.00% 2 Missing ⚠️
webui/react/src/components/Searches/columns.ts 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10066      +/-   ##
==========================================
- Coverage   54.45%   50.46%   -4.00%     
==========================================
  Files        1267      957     -310     
  Lines      159440   130680   -28760     
  Branches     3633     3633              
==========================================
- Hits        86820    65943   -20877     
+ Misses      72486    64603    -7883     
  Partials      134      134              
Flag Coverage Δ
harness ?
web 53.93% <24.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
webui/react/src/components/Searches/columns.ts 51.78% <83.33%> (-0.11%) ⬇️
webui/react/src/utils/flatRun.ts 97.61% <75.00%> (-1.54%) ⬇️
webui/react/src/pages/F_ExpList/expListColumns.ts 20.98% <0.00%> (+0.04%) ⬆️
webui/react/src/pages/FlatRuns/columns.ts 18.29% <0.00%> (-0.20%) ⬇️
webui/react/src/pages/FlatRuns/FlatRuns.tsx 11.12% <5.55%> (-0.01%) ⬇️

... and 310 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant