Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: version upgrade notification bug [CM-411] #10069

Merged
merged 7 commits into from
Oct 22, 2024

safer isDev

2f77e13
Select commit
Loading
Failed to load commit list.
Merged

fix: version upgrade notification bug [CM-411] #10069

safer isDev
2f77e13
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 22, 2024 in 0s

50.65% (-3.97%) compared to 2356f91

View this Pull Request on Codecov

50.65% (-3.97%) compared to 2356f91

Details

Codecov Report

Attention: Patch coverage is 71.11111% with 26 lines in your changes missing coverage. Please review.

Project coverage is 50.65%. Comparing base (2356f91) to head (2f77e13).
Report is 35 commits behind head on main.

Files with missing lines Patch % Lines
webui/react/src/App.tsx 0.00% 12 Missing ⚠️
webui/react/src/pages/SignIn.tsx 0.00% 9 Missing ⚠️
webui/react/src/utils/browser.ts 16.66% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10069      +/-   ##
==========================================
- Coverage   54.62%   50.65%   -3.97%     
==========================================
  Files        1260      950     -310     
  Lines      157621   128964   -28657     
  Branches     3632     3635       +3     
==========================================
- Hits        86102    65328   -20774     
+ Misses      71385    63503    -7882     
+ Partials      134      133       -1     
Files with missing lines Coverage Δ
webui/react/src/components/JupyterLabButton.tsx 100.00% <100.00%> (ø)
webui/react/src/components/VersionChecker.tsx 100.00% <100.00%> (ø)
webui/react/src/utils/browser.ts 46.55% <16.66%> (-1.24%) ⬇️
webui/react/src/pages/SignIn.tsx 0.00% <0.00%> (ø)
webui/react/src/App.tsx 0.00% <0.00%> (ø)

... and 310 files with indirect coverage changes