Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix update invariant config and constraints #10078

Merged
merged 2 commits into from
Oct 17, 2024
Merged

Conversation

amandavialva01
Copy link
Contributor

@amandavialva01 amandavialva01 commented Oct 17, 2024

Ticket

CM-573

Description

When configs and constraints are both set for a given scope, updating the config policies to only use policy (config or constraints) doesn't work (the deleted config policy remains enforced).

Test Plan

CI passes (automated testing).

Checklist

  • Changes have been manually QA'd
  • New features have been approved by the corresponding PM
  • User-facing API changes have the "User-facing API Change" label
  • Release notes have been added as a separate file under docs/release-notes/
    See Release Note for details.
  • Licenses have been included for new code which was copied and/or modified from any external code

@amandavialva01 amandavialva01 requested a review from a team as a code owner October 17, 2024 17:52
@cla-bot cla-bot bot added the cla-signed label Oct 17, 2024
Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.42%. Comparing base (3ca3418) to head (61bcd73).
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10078      +/-   ##
==========================================
- Coverage   54.43%   54.42%   -0.01%     
==========================================
  Files        1262     1262              
  Lines      158901   158895       -6     
  Branches     3631     3630       -1     
==========================================
- Hits        86494    86481      -13     
- Misses      72273    72280       +7     
  Partials      134      134              
Flag Coverage Δ
backend 45.51% <100.00%> (-0.02%) ⬇️
harness 72.74% <ø> (ø)
web 53.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ternal/configpolicy/postgres_task_config_policy.go 91.83% <100.00%> (-0.90%) ⬇️

... and 4 files with indirect coverage changes

Copy link

netlify bot commented Oct 17, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit 61bcd73
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/6711668e4af282000879cab0

Copy link
Contributor

@kkunapuli kkunapuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there's some test failures. I checked out the branch and everything works with devcluster locally ... probably something specific to how the tests are defined?

Great work!

@amandavialva01
Copy link
Contributor Author

Looks like there's some test failures. I checked out the branch and everything works with devcluster locally ... probably something specific to how the tests are defined?

Great work!

It also passed for me locally before I pushed! But then started failing locally as well so I assumed I ran the wrong test. Good to know it wasn't just me lol!
I corrected the JSONs :D

@amandavialva01 amandavialva01 enabled auto-merge (squash) October 17, 2024 19:43
@amandavialva01 amandavialva01 merged commit 2e822b7 into main Oct 17, 2024
82 of 94 checks passed
@amandavialva01 amandavialva01 deleted the amanda/CM573 branch October 17, 2024 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants