-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fix update invariant config and constraints #10078
Conversation
CM-573: #in-review
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10078 +/- ##
==========================================
- Coverage 54.43% 54.42% -0.01%
==========================================
Files 1262 1262
Lines 158901 158895 -6
Branches 3631 3630 -1
==========================================
- Hits 86494 86481 -13
- Misses 72273 72280 +7
Partials 134 134
Flags with carried forward coverage won't be shown. Click here to find out more.
|
✅ Deploy Preview for determined-ui canceled.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like there's some test failures. I checked out the branch and everything works with devcluster locally ... probably something specific to how the tests are defined?
Great work!
It also passed for me locally before I pushed! But then started failing locally as well so I assumed I ran the wrong test. Good to know it wasn't just me lol! |
Ticket
CM-573
Description
When configs and constraints are both set for a given scope, updating the config policies to only use policy (config or constraints) doesn't work (the deleted config policy remains enforced).
Test Plan
CI passes (automated testing).
Checklist
docs/release-notes/
See Release Note for details.