Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add actual select all to glide tables [ET-238] #10081

Merged
merged 24 commits into from
Oct 25, 2024

Conversation

EmilyBonar
Copy link
Contributor

@EmilyBonar EmilyBonar commented Oct 18, 2024

Ticket

ET-238
Ticket body:

When All Checkbox is selected, first select all visible runs, and show actual select all. When filter is applied, select all filtered runs.

For select checkbox – remove the “Select 5, 10, 25” options and remove the dropdown. Instead, we will simplify the experience to select all visible, select all in table, and none selected.

Also ensure this works on the new Flat Runs and Searches Views. The current flat runs view doesn’t have the count displayed at the moment.

All actions should be available on the frontend when the user has an actual select all selection or the selection contains otherwise unloaded runs or searches.

Description

When selection header is clicked it selects all items on page
Screenshot 2024-10-18 at 14-01-41 Project Details - Determined

When "Select all runs in table" is clicked it selects all items in table
Screenshot 2024-10-18 at 14-01-59 Project Details - Determined

When selection header is clicked again it unselects all items on page
Screenshot 2024-10-18 at 14-04-04 Project Details - Determined

Test Plan

  • Ensure selection works as expected across Runs, Searches, and Experiments tables
  • Ensure bulk actions work as expected across Runs, Searches, and Experiments tables
  • Ensure comparison view works as expected across Runs and Experiments tables

Checklist

  • Changes have been manually QA'd
  • New features have been approved by the corresponding PM
  • User-facing API changes have the "User-facing API Change" label
  • Release notes have been added as a separate file under docs/release-notes/
    See Release Note for details.
  • Licenses have been included for new code which was copied and/or modified from any external code

@EmilyBonar EmilyBonar requested a review from a team as a code owner October 18, 2024 17:59
@cla-bot cla-bot bot added the cla-signed label Oct 18, 2024
Copy link

netlify bot commented Oct 18, 2024

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit a796368
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/671bb14df22dd00008227524
😎 Deploy Preview https://deploy-preview-10081--determined-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@EmilyBonar EmilyBonar requested review from ashtonG and removed request for johnkim-det October 18, 2024 18:00
@EmilyBonar EmilyBonar force-pushed the emilybonar/actual-select-all branch 2 times, most recently from 09e247c to 74db3c5 Compare October 21, 2024 17:45
webui/react/src/components/ComparisonView.tsx Outdated Show resolved Hide resolved
webui/react/src/components/ComparisonView.tsx Outdated Show resolved Hide resolved
webui/react/src/components/Searches/Searches.tsx Outdated Show resolved Hide resolved
webui/react/src/pages/FlatRuns/FlatRunActionButton.tsx Outdated Show resolved Hide resolved
Copy link

codecov bot commented Oct 22, 2024

Codecov Report

Attention: Patch coverage is 59.86547% with 358 lines in your changes missing coverage. Please review.

Project coverage is 50.76%. Comparing base (deb3772) to head (a796368).
Report is 16 commits behind head on main.

Files with missing lines Patch % Lines
webui/react/src/hooks/useSelection.ts 56.21% 88 Missing ⚠️
webui/react/src/pages/FlatRuns/FlatRuns.tsx 11.36% 78 Missing ⚠️
...bui/react/src/pages/F_ExpList/F_ExperimentList.tsx 0.00% 60 Missing ⚠️
webui/react/src/components/TableActionBar.tsx 59.30% 35 Missing ⚠️
webui/react/src/components/ExperimentMoveModal.tsx 53.48% 20 Missing ⚠️
webui/react/src/utils/task.ts 22.22% 14 Missing ⚠️
webui/react/src/components/Searches/Searches.tsx 75.47% 13 Missing ⚠️
webui/react/src/services/api.ts 84.28% 11 Missing ⚠️
webui/react/src/components/ComparisonView.tsx 66.66% 10 Missing ⚠️
...i/react/src/pages/FlatRuns/FlatRunActionButton.tsx 85.00% 6 Missing ⚠️
... and 5 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10081      +/-   ##
==========================================
- Coverage   54.55%   50.76%   -3.80%     
==========================================
  Files        1267      958     -309     
  Lines      159525   131025   -28500     
  Branches     3637     3662      +25     
==========================================
- Hits        87035    66515   -20520     
+ Misses      72357    64377    -7980     
  Partials      133      133              
Flag Coverage Δ
harness ?
web 54.30% <59.86%> (+0.27%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
.../react/src/components/ComparisonView.test.mock.tsx 99.32% <100.00%> (+0.01%) ⬆️
.../react/src/components/ExperimentActionDropdown.tsx 79.84% <100.00%> (+0.05%) ⬆️
...bui/react/src/components/ExperimentCreateModal.tsx 81.58% <100.00%> (ø)
webui/react/src/components/RunActionDropdown.tsx 95.61% <100.00%> (+0.01%) ⬆️
...components/RunFilterInterstitialModalComponent.tsx 97.77% <100.00%> (-0.08%) ⬇️
...ages/ExperimentDetails/ExperimentDetailsHeader.tsx 74.35% <100.00%> (+0.03%) ⬆️
webui/react/src/utils/experiment.ts 89.92% <100.00%> (ø)
webui/react/src/pages/ExperimentList.tsx 0.00% <0.00%> (ø)
webui/react/src/components/LoadableCount.tsx 94.31% <86.11%> (-5.69%) ⬇️
...ui/react/src/components/SearchTensorBoardModal.tsx 80.00% <44.44%> (ø)
... and 12 more

... and 310 files with indirect coverage changes

@EmilyBonar EmilyBonar requested a review from ashtonG October 23, 2024 18:44
@EmilyBonar EmilyBonar requested a review from ashtonG October 23, 2024 19:45
@EmilyBonar EmilyBonar force-pushed the emilybonar/actual-select-all branch from a53ea96 to 45aef30 Compare October 24, 2024 13:42
Copy link
Contributor

@ashtonG ashtonG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, we're close -- there are one or two places where we might have overlooked something.

i think consolidating selection state and operations is a good move.

webui/react/src/pages/FlatRuns/FlatRuns.tsx Outdated Show resolved Hide resolved
webui/react/src/pages/FlatRuns/FlatRuns.tsx Outdated Show resolved Hide resolved
webui/react/src/components/TableActionBar.tsx Outdated Show resolved Hide resolved
@EmilyBonar EmilyBonar requested a review from ashtonG October 24, 2024 18:00
@EmilyBonar EmilyBonar enabled auto-merge (squash) October 24, 2024 18:58
@EmilyBonar EmilyBonar requested a review from a team as a code owner October 24, 2024 22:13
@EmilyBonar EmilyBonar requested a review from JComins000 October 25, 2024 15:31
@EmilyBonar EmilyBonar assigned JComins000 and unassigned ashtonG Oct 25, 2024
@EmilyBonar EmilyBonar requested review from davidfluck-hpe and removed request for JComins000 October 25, 2024 18:02
@davidfluck-hpe davidfluck-hpe merged commit 834eeda into main Oct 25, 2024
82 of 94 checks passed
@davidfluck-hpe davidfluck-hpe deleted the emilybonar/actual-select-all branch October 25, 2024 18:09
hkang1 added a commit that referenced this pull request Nov 18, 2024
hkang1 added a commit that referenced this pull request Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants