Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: improve documentation surrounding slot caps helm configuration #10090

Merged
merged 2 commits into from
Oct 23, 2024
Merged

chore: improve documentation surrounding slot caps helm configuration #10090

merged 2 commits into from
Oct 23, 2024

Conversation

amandavialva01
Copy link
Contributor

@amandavialva01 amandavialva01 commented Oct 21, 2024 •
edited by jira bot
Loading

Ticket

CM-579

Description

Improve documentation surrounding slot caps helm configuration

Test Plan

Docs, CI passes.

Checklist

  • Changes have been manually QA'd
  • New features have been approved by the corresponding PM
  • User-facing API changes have the "User-facing API Change" label
  • Release notes have been added as a separate file under docs/release-notes/
    See Release Note for details.
  • Licenses have been included for new code which was copied and/or modified from any external code

@cla-bot cla-bot bot added the cla-signed label Oct 21, 2024
@determined-ci determined-ci requested a review from a team October 21, 2024 19:47
@determined-ci determined-ci added the documentation Improvements or additions to documentation label Oct 21, 2024
@netlify Netlify
Copy link

netlify bot commented Oct 21, 2024 •
edited
Loading

✅ Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit 51daec6
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/671943ac587e460008ae5e3e
😎 Deploy Preview https://deploy-preview-10090--determined-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

tara-hpe
tara-hpe approved these changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@tara-hpe tara-hpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@determined-ci determined-ci requested a review from a team October 23, 2024 18:43
@amandavialva01 amandavialva01 enabled auto-merge (squash) October 23, 2024 18:43
@amandavialva01 amandavialva01 enabled auto-merge (squash) October 23, 2024 18:43
@amandavialva01 amandavialva01 merged commit f45ebb9 into main Oct 23, 2024
74 of 89 checks passed
@amandavialva01 amandavialva01 deleted the amanda/CM579 branch October 23, 2024 18:50
thiagodallacqua-hpe pushed a commit that referenced this pull request Oct 28, 2024
@amandavialva01 @thiagodallacqua-hpe
chore: improve documentation surrounding slot caps helm configuration (…
3c602a5 
…#10090)

CM-579: #done
thiagodallacqua-hpe pushed a commit that referenced this pull request Oct 28, 2024
@amandavialva01 @thiagodallacqua-hpe
chore: improve documentation surrounding slot caps helm configuration (…
49f2287 
…#10090)

CM-579: #done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tara-hpe tara-hpe tara-hpe approved these changes

Assignees
No one assigned
Labels
cla-signed documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amandavialva01 @tara-hpe @determined-ci