chore: do not log error for resource pools with zero agents #9960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9960 +/- ##
==========================================
+ Coverage 54.51% 54.71% +0.20%
==========================================
Files 1252 835 -417
Lines 156703 82633 -74070
Branches 3600 0 -3600
==========================================
- Hits 85421 45216 -40205
+ Misses 71149 37417 -33732
+ Partials 133 0 -133
Flags with carried forward coverage won't be shown. Click here to find out more.
|
| // We raise an error in the logs. | ||
| if len(deviceTypeCount) != 1 { | ||
| // We raise an error in the logs if there is more than one slot type. | ||
| if len(deviceTypeCount) < 1 { |
There was a problem hiding this comment.
Suggested change
| if len(deviceTypeCount) < 1 { | |
| if len(deviceTypeCount) > 1 { |
Should it be this?
There was a problem hiding this comment.
oops yes, good catch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Description
Just fix the log to only print when there a multiple slot types assigned to one pool, ignore in the zero case. This avoids cases where pools don't have any agents assigned and the logs are spammed with this error message.
Test Plan
N/A
Checklist
docs/release-notes/See Release Note for details.