Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: do not log error for resource pools with zero agents #9960

Merged
merged 2 commits into from
Sep 20, 2024
Merged

chore: do not log error for resource pools with zero agents #9960

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2dd1e34
chore: do not log error for resource pools with zero agents
carolinaecalderon Sep 19, 2024
22bcf82
edit
carolinaecalderon Sep 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions master/internal/rm/agentrm/summaries.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,8 @@ func (rp *resourcePool) resourceSummaryFromAgentStates(
}

// If we have heterogenous slots, we default to`UNSPECIFIED` aka `device.ZeroSlot`.
// We raise an error in the logs.
if len(deviceTypeCount) != 1 {
// We raise an error in the logs if there is more than one slot type.
if len(deviceTypeCount) > 1 {
rp.syslog.Errorf("resource pool has unspecified slot type with %v total slot types", len(deviceTypeCount))
} else {
for deviceType := range deviceTypeCount {
Expand Down
Loading