-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small proposed changes for Docker image creation #519
Comments
Remove reduncant -it arguments to docker and add --rm to remove the container after use. Fixes #519
Remove reduncant -it arguments to docker and add --rm to remove the container after use. Fixes #519 Signed-off-by: Jarno Elovirta <[email protected]>
Remove reduncant -it arguments to docker and add --rm to remove the container after use. Fixes #519 Signed-off-by: Jarno Elovirta <[email protected]>
@raducoravu Thanks for these suggestions, and thanks to @jelovirt for implementing the flag changes. 🙇
@raducoravu @jelovirt Should we implement those suggestions directly in dita-ot/Dockerfile, or do we need to preserve that as is for backwards compatibility? |
IMO the Some changes in the Oxygen DITA-OT Dockerfile may be worth investigating, but it's a matter of coding style and e.g. the docs are not needed in the Docker image. |
Based on this article:
https://www.dita-ot.org/dev/topics/using-docker-images
I experimented with creating a Docker image for the Oxygen Publishing Engine:
https://blog.oxygenxml.com/topics/creating_a_docker_image_for_the_oxygen_publishing_engine.html
A couple of remarks about the proposed command to run docker in the DITA OT documentation:
Those "-it" flags do not seem useful in this context, also ideally the "--rm" flag would be added to automatically remove the container after it finishes because containers would keep accumulating although they are useless once they produce the output.
The "--name dita-ot-publish" param can also be used to give a human readable name to the container.
I started from the DITA OT Dockerfile (so thanks for having it):
https://github.com/dita-ot/dita-ot/blob/develop/Dockerfile
and I created my equivalent:
https://github.com/oxygenxml/blog/blob/master/build/Dockerfile
I made some simplifications by avoiding things like:
and just moving the entire dita-ot folder to the "/opt/app" subfolder.
The text was updated successfully, but these errors were encountered: