Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Docker usage #520

Conversation

jelovirt
Copy link
Member

Remove reduncant -it arguments to docker and add --rm to remove the container after use.

Fixes #519

@jelovirt jelovirt linked an issue Dec 21, 2023 that may be closed by this pull request
Remove reduncant -it arguments to docker and add --rm to remove the container after use.

Fixes #519

Signed-off-by: Jarno Elovirta <[email protected]>
@jelovirt jelovirt force-pushed the feature/519-small-proposed-changes-for-docker-image-creation branch from ff022df to 1f10966 Compare December 21, 2023 13:59
@jelovirt jelovirt requested a review from infotexture December 21, 2023 14:00
@jelovirt jelovirt added the enhancement Changes to an existing topic or feature label Dec 21, 2023
Copy link
Member

@infotexture infotexture left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM, thanks!

@infotexture infotexture merged commit 4242a72 into develop Dec 21, 2023
5 checks passed
@infotexture infotexture deleted the feature/519-small-proposed-changes-for-docker-image-creation branch December 21, 2023 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Changes to an existing topic or feature
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Small proposed changes for Docker image creation
2 participants