Merge InitModifier and UpdateModifier
#292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djeedai
added
A - modifiers
Merge the `InitModifier` and `UpdateModifier` supertraits into their `Modifier` subtrait, and delete them. This unifies handling of modifiers for the init and update contexts. The modifiers can now easily be compatible with both contexts by simply returning the appropriate `ModifierContext` without having to duplicate the implementation into each supertrait. At this time, `RenderModifier` still contains some hard-coded elements not yet transitioned to a fully data driven model (mainly, anything related to texture resources), and therefore cannot be merged too. However the longer term plan is to eventually merge it and retain a single `Modifier` trait.
djeedai
force-pushed
the
u/merge-init-update-traits
branch
from
9946ad4 to
c07a460
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge the
InitModifierandUpdateModifiersupertraits into theirModifiersubtrait, and delete them. This unifies handling of modifiers for the init and update contexts. The modifiers can now easily be compatible with both contexts by simply returning the appropriateModifierContextwithout having to duplicate the implementation into each supertrait.At this time,
RenderModifierstill contains some hard-coded elements not yet transitioned to a fully data driven model (mainly, anything related to texture resources), and therefore cannot be merged too. However the longer term plan is to eventually merge it and retain a singleModifiertrait.