Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(feedback): correct the permission requirement for removing feedback relation #3317

Merged
merged 4 commits into from
Nov 6, 2024
Merged

fix(feedback): correct the permission requirement for removing feedback relation #3317

merged 4 commits into from
Nov 6, 2024

Conversation

norawl
Copy link
Contributor

@norawl norawl commented Oct 20, 2024 •
edited
Loading

Changes:

  • Updated the RemoveFeedbackRelationView which used a permission from the events app, to use the feedback.delete_feedbackrelation permission - This fixes the WrongAppError
  • Added a test for removing a feedback from an event

@norawl
fix(feedback): correct permission requirement for removing feedback r…
76d55ff 
…elation

Updated the RemoveFeedbackRelationView which used a permission from the events app, to use the feedback.delete_feedbackrelation permission
@norawl norawl requested a review from henrikhorluck October 20, 2024 09:59
@norawl norawl self-assigned this Oct 20, 2024
@norawl norawl linked an issue Nov 6, 2024 that may be closed by this pull request
Removing feedback from events does not work for some users. #2573
Closed
@norawl norawl marked this pull request as ready for review November 6, 2024 17:40
@henrikhorluck henrikhorluck added this pull request to the merge queue Nov 6, 2024
Merged via the queue into main with commit a65b111 Nov 6, 2024
8 checks passed
@henrikhorluck henrikhorluck deleted the fix-wrongapperror-when-deleting-feedback branch November 6, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henrikhorluck henrikhorluck henrikhorluck approved these changes

Assignees

@norawl norawl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Removing feedback from events does not work for some users.
2 participants
@norawl @henrikhorluck