fix(feedback): correct the permission requirement for removing feedback relation

apps/events/dashboard/tests.py

@@ -1,12 +1,16 @@
+from datetime import timedelta
+
 from django.contrib.auth.models import Permission
 from django.test import TestCase
 from django.urls import reverse
 from django.utils import timezone
 from django_dynamic_fixture import G
+from guardian.shortcuts import assign_perm
 from rest_framework import status
 
 from apps.authentication.models import OnlineUser as User
 from apps.events.models import AttendanceEvent, Event
+from apps.feedback.models import Feedback, FeedbackRelation, TextQuestion
 
 
 def create_generic_attendance_event():
@@ -23,6 +27,7 @@ def add_permissions(user):
     user.user_permissions.add(
         Permission.objects.filter(codename="view_event").first(),
         Permission.objects.filter(codename="add_event").first(),
+        Permission.objects.filter(codename="delete_feedbackrelation").first(),
     )
 
 
@@ -62,3 +67,26 @@ def test_dashboard_events_create(self):
         response = self.client.get(url)
 
         self.assertEqual(response.status_code, status.HTTP_200_OK)
+
+    def test_dashboard_remove_feedback_from_event(self):
+        add_permissions(self.user)
+
+        event = create_generic_attendance_event()
+        feedback = Feedback.objects.create(author=self.user)
+        TextQuestion.objects.create(feedback=feedback)
+        deadline = timezone.now().date() + timedelta(days=4)
+
+        feedbackrelation = FeedbackRelation.objects.create(
+            feedback=feedback, content_object=event, deadline=deadline, active=True
+        )
+
+        assign_perm("delete_feedbackrelation", self.user, feedbackrelation)
+        self.assertTrue(self.user.has_perm("feedback.delete_feedbackrelation"))
+
+        url = reverse(
+            "dashboard_events_remove_feedback",
+            kwargs={"event_id": event.id, "pk": feedback.id},
+        )
+        response = self.client.post(url)
+
+        self.assertEqual(response.status_code, status.HTTP_302_FOUND)

apps/events/dashboard/views.py

@@ -185,7 +185,8 @@ def form_valid(self, form):
 
 class RemoveFeedbackRelationView(DashboardObjectPermissionMixin, DeleteView):
     model = FeedbackRelation
-    permission_required = "events.add_attendanceevent"
+
+    permission_required = "feedback.delete_feedbackrelation"
 
     def get_success_url(self):
         return reverse(