Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more NRT examples #1225

Open
wants to merge 9 commits into
base: draft-v8
Choose a base branch
from

Conversation

BillWagner
Copy link
Member

Fixes #1214

Add examples as noted in the referenced comments.

Fixes dotnet#1214

Add examples as noted in the referenced comments.
@BillWagner BillWagner added the meeting: discuss This issue should be discussed at the next TC49-TG2 meeting label Dec 2, 2024
Copy link
Contributor

@Nigel-Ecma Nigel-Ecma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a left-over para, or one that was going to be replaced.

I think “The compiler” here should probably always be ”A compiler” – there are a few of the latter already.

standard/types.md Show resolved Hide resolved
standard/types.md Outdated Show resolved Hide resolved
Replace instances of "the compiler" with "a compiler" as it relates to what actions a compiler might take while performing static nullable analysis.
@BillWagner
Copy link
Member Author

@Nigel-Ecma @RexJaeschke

I think “The compiler” here should probably always be ”A compiler” – there are a few of the latter already.

I did replace instances of "the compiler" as it relates to this PR with "a compiler". A search in the standard uncovers 68 other instances of "the compiler". Some should not be changed. They are part of a longer phrase like "the compiler generated backing field" for properties and field like events.

Should I change others where the language is similar to those Nigel mentioned in this PR? Should I add it to this PR, or create a separate smaller PR?

@RexJaeschke
Copy link
Contributor

@BillWagner Yes, please change them, as appropriate. If there are occurrences in other topics then I think a separate PR would be best, making it a general editorial fix.

@Nigel-Ecma
Copy link
Contributor

@BillWagner & @RexJaeschke – I agree with Rex to change the ones you see.

It is easy to go down a rabbit hole here; I started as Bill did and saw each “the” needs to be examined – e.g. as in the backing field example “the” refers to the field and not the compiler. From there I started looking into “automatically” – as in “the compiler automatically…” – and these often should at least be something like “a compiler shall/must/may” – this is a spec not a description after all. Once we get to these we need to decide what is being required etc. Rabbit hole! This language I expect in many cases dates from the descriptive material from which the 1st edition was written, it will be a long road and incremental is the way to go.

standard/types.md Outdated Show resolved Hide resolved
standard/types.md Outdated Show resolved Hide resolved
standard/types.md Outdated Show resolved Hide resolved
standard/types.md Outdated Show resolved Hide resolved
standard/types.md Outdated Show resolved Hide resolved
standard/types.md Outdated Show resolved Hide resolved
standard/types.md Outdated Show resolved Hide resolved
standard/types.md Show resolved Hide resolved
standard/types.md Outdated Show resolved Hide resolved
@BillWagner
Copy link
Member Author

Yes, please change them, as appropriate. If there are occurrences in other topics then I think a separate PR would be best, making it a general editorial fix.

Added in #1126

@BillWagner BillWagner closed this Dec 4, 2024
@BillWagner BillWagner reopened this Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meeting: discuss This issue should be discussed at the next TC49-TG2 meeting
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add additional null state analysis examples
4 participants