Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more NRT examples #1225

Open
wants to merge 9 commits into
base: draft-v8
Choose a base branch
from
Open

Add more NRT examples #1225

wants to merge 9 commits into from

Commits on Dec 2, 2024

  1. Add more NRT examples 

    Fixes dotnet#1214

Add examples as noted in the referenced comments.
    @BillWagner
    BillWagner committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    e31ea69 View commit details
    Browse the repository at this point in the history

  2. fix grammar note

    @BillWagner
    BillWagner committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    6a0c9d0 View commit details
    Browse the repository at this point in the history

  3. Fix examples

    @BillWagner
    BillWagner committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    3ff26c9 View commit details
    Browse the repository at this point in the history

  4. update expected exception

    @BillWagner
    BillWagner committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    ab92e1f View commit details
    Browse the repository at this point in the history

Commits on Dec 3, 2024

  1. Replace "the compiler" with "a compiler", part 1. 

    Replace instances of "the compiler" with "a compiler" as it relates to what actions a compiler might take while performing static nullable analysis.
    @BillWagner
    BillWagner committed Dec 3, 2024
    Configuration menu
    Copy the full SHA
    9cde1c0 View commit details
    Browse the repository at this point in the history

Commits on Dec 4, 2024

  1. Apply suggestions from code review 

    Co-authored-by: Jon Skeet <[email protected]>
    @BillWagner @jskeet
    BillWagner and jskeet authored Dec 4, 2024
    Configuration menu
    Copy the full SHA
    0aa4f52 View commit details
    Browse the repository at this point in the history

  2. Respond to reviews

    @BillWagner
    BillWagner committed Dec 4, 2024
    Configuration menu
    Copy the full SHA
    be10ce1 View commit details
    Browse the repository at this point in the history

  3. respond to feedback 2.

    @BillWagner
    BillWagner committed Dec 4, 2024
    Configuration menu
    Copy the full SHA
    3c967c7 View commit details
    Browse the repository at this point in the history

  4. fix expected warnings.

    @BillWagner
    BillWagner committed Dec 4, 2024
    Configuration menu
    Copy the full SHA
    e799452 View commit details
    Browse the repository at this point in the history