feat(favicon): add gatsby-plugin-manifest for favicons #473
Conversation
| background_color: '#EFDA4F', | ||
| theme_color: '#039998', | ||
| display: 'standalone', | ||
| icon: './static/dsmJS.svg' |
There was a problem hiding this comment.
could this pull from a package, or does it need to be a local path? we already have this in the components repo (maybe thats where you pulled it in from). it would be nice if we could maintain a single copy
There was a problem hiding this comment.
i recently switched over to this plugin for my personal site, and the unfortunate answer is kinda.
i didn't find a way to resolve the path like node does so that it could be referenced relative to the package. seems unlikely to be a problem where the deduping algorithm would move it, but that is my hesitation.
| background_color: '#EFDA4F', | ||
| theme_color: '#039998', |
There was a problem hiding this comment.
this highlights that we still need to export brand colors from somewhere that is reusable. for now that probably means the components package, but eventually maybe a brand or design system package
There was a problem hiding this comment.
for awareness, i at least created an issue to track getting this done at some point
This should resolve #7.