Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(favicon): add gatsby-plugin-manifest for favicons #473

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat(favicon): add gatsby-plugin-manifest for favicons #473

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions gatsby-config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,20 @@ module.exports = {
'MarkdownRemark.frontmatter.host': 'MarkdownRemark.frontmatter.location'
},
plugins: [
{
resolve: 'gatsby-plugin-manifest',
options: {
name: 'dsmJS',
short_name: 'dsmJS',
description: 'Des Moines JavaScript User Group',
lang: 'en',
start_url: '/',
background_color: '#EFDA4F',
theme_color: '#039998',
Comment on lines +20 to +21
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this highlights that we still need to export brand colors from somewhere that is reusable. for now that probably means the components package, but eventually maybe a brand or design system package

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for awareness, i at least created an issue to track getting this done at some point

display: 'standalone',
icon: './static/dsmJS.svg'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could this pull from a package, or does it need to be a local path? we already have this in the components repo (maybe thats where you pulled it in from). it would be nice if we could maintain a single copy

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i recently switched over to this plugin for my personal site, and the unfortunate answer is kinda.

i didn't find a way to resolve the path like node does so that it could be referenced relative to the package. seems unlikely to be a problem where the deduping algorithm would move it, but that is my hesitation.

}
},
{
resolve: 'gatsby-transformer-remark',
options: {
Expand Down
Loading