Add Serde Feature #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Neotamandua
reviewed
Nov 25, 2024
d-sonuga
force-pushed
the
add-serde-feature-execution-core
branch
2 times, most recently
from
f09be04 to
e34731a
Compare
|
It should be noted that the decision was made in this PR to consistently use base58 encoding for all keys and key-related types as the way serde handles these datatypes. This includes secret keys and signatures. This also means that we aim to apply the same encoding rule to serde features of phoenix keys and their respective types, unless they are already defined to be encoded in a different format. |
Neotamandua
requested changes
Nov 27, 2024
d-sonuga
force-pushed
the
add-serde-feature-execution-core
branch
from
9b8d533 to
ed52ff1
Compare
Neotamandua
requested review from
Neotamandua,
miloszm,
HDauven,
Daksh14 and
moCello
d-sonuga
force-pushed
the
add-serde-feature-execution-core
branch
2 times, most recently
from
0b2cd29 to
393ade1
Compare
Neotamandua
requested changes
Dec 4, 2024
d-sonuga
force-pushed
the
add-serde-feature-execution-core
branch
6 times, most recently
from
028d3cd to
a28a10f
Compare
d-sonuga
force-pushed
the
add-serde-feature-execution-core
branch
from
a28a10f to
6362a7d
Compare
Closed
d-sonuga
changed the title
Serialize and Deserialize for execution-core
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For dusk-network/rusk#2773 and #21.