Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Remove ValidateBasic in cli #470

Merged
merged 1 commit into from
Jan 12, 2024
Merged

refactor: Remove ValidateBasic in cli #470

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions x/rollapp/client/cli/tx_create_rollapp.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,9 +62,6 @@ func CmdCreateRollapp() *cobra.Command {
metadatas,
)

if err := msg.ValidateBasic(); err != nil {
return err
}
return tx.GenerateOrBroadcastTxCLI(clientCtx, cmd.Flags(), msg)
},
}
Expand Down
4 changes: 1 addition & 3 deletions x/rollapp/client/cli/tx_update_state.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,9 +55,7 @@
argVersion,
argBDs,
)
if err := msg.ValidateBasic(); err != nil {
return err
}

Check warning on line 58 in x/rollapp/client/cli/tx_update_state.go

View check run for this annotation

Codecov / codecov/patch

x/rollapp/client/cli/tx_update_state.go#L58 

Added line #L58 was not covered by tests
return tx.GenerateOrBroadcastTxCLI(clientCtx, cmd.Flags(), msg)
},
}
Expand Down
3 changes: 0 additions & 3 deletions x/sequencer/client/cli/tx_create_sequencer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,9 +50,6 @@ func CmdCreateSequencer() *cobra.Command {
return err
}

if err := msg.ValidateBasic(); err != nil {
return err
}
return tx.GenerateOrBroadcastTxCLI(clientCtx, cmd.Flags(), msg)
},
}
Expand Down
4 changes: 0 additions & 4 deletions x/streamer/client/cli/tx_create_stream.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,10 +74,6 @@ func NewCmdSubmitCreateStreamProposal() *cobra.Command {
return err
}

if err = msg.ValidateBasic(); err != nil {
return err
}

txf := tx.NewFactoryCLI(clientCtx, cmd.Flags()).WithTxConfig(clientCtx.TxConfig).WithAccountRetriever(clientCtx.AccountRetriever)
return tx.GenerateOrBroadcastTxWithFactory(clientCtx, txf, msg)
},
Expand Down
4 changes: 0 additions & 4 deletions x/streamer/client/cli/tx_replace_distribution.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,10 +45,6 @@ func NewCmdSubmitReplaceStreamDistributionProposal() *cobra.Command {
return err
}

if err = msg.ValidateBasic(); err != nil {
return err
}

txf := tx.NewFactoryCLI(clientCtx, cmd.Flags()).WithTxConfig(clientCtx.TxConfig).WithAccountRetriever(clientCtx.AccountRetriever)
return tx.GenerateOrBroadcastTxWithFactory(clientCtx, txf, msg)
},
Expand Down
4 changes: 0 additions & 4 deletions x/streamer/client/cli/tx_terminate_stream.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,10 +41,6 @@ func NewCmdSubmitTerminateStreamProposal() *cobra.Command {
return err
}

if err = msg.ValidateBasic(); err != nil {
return err
}

txf := tx.NewFactoryCLI(clientCtx, cmd.Flags()).WithTxConfig(clientCtx.TxConfig).WithAccountRetriever(clientCtx.AccountRetriever)
return tx.GenerateOrBroadcastTxWithFactory(clientCtx, txf, msg)
},
Expand Down
4 changes: 0 additions & 4 deletions x/streamer/client/cli/tx_update_distribution.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,10 +45,6 @@ func NewCmdSubmitUpdateStreamDistributionProposal() *cobra.Command {
return err
}

if err = msg.ValidateBasic(); err != nil {
return err
}

txf := tx.NewFactoryCLI(clientCtx, cmd.Flags()).WithTxConfig(clientCtx.TxConfig).WithAccountRetriever(clientCtx.AccountRetriever)
return tx.GenerateOrBroadcastTxWithFactory(clientCtx, txf, msg)
},
Expand Down
Loading