Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Remove ValidateBasic in cli #470

Merged
merged 1 commit into from
Jan 12, 2024
Merged

refactor: Remove ValidateBasic in cli #470

merged 1 commit into from
Jan 12, 2024

Conversation

lukema95
Copy link
Contributor

PR Standards

Description

The ValidateBasic function has been called in the GenerateOrBroadcastTxWithFactory function, so we no longer need to add the ValidateBasic function when writing Cli. Related PRs can be viewed at: cosmos/cosmos-sdk#9236 (comment)

Opening a pull request should be able to meet the following requirements:


For Author:

  • Targeted PR against the correct branch
  • included the correct type prefix in the PR title
  • Linked to the GitHub issue with discussion and accepted design
  • Targets only one GitHub issue
  • Wrote unit and integration tests
  • Wrote relevant migration scripts if necessary
  • All CI checks have passed
  • Added relevant godoc comments

For Reviewer:

  • confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • confirmed all author checklist items have been addressed

---;

After reviewer approval:

  • In case it targets the main branch, PR should be squashed and merged.
  • In case the PR targets a release branch, PR should be rebased.

@lukema95 lukema95 requested a review from a team as a code owner December 30, 2023 15:55
Copy link

codecov bot commented Dec 31, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (d548bc8) 30.96% compared to head (65ca2bb) 30.99%.

Files Patch % Lines
x/rollapp/client/cli/tx_update_state.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #470      +/-   ##
==========================================
+ Coverage   30.96%   30.99%   +0.02%     
==========================================
  Files         165      165              
  Lines       25138    25118      -20     
==========================================
  Hits         7785     7785              
+ Misses      16104    16084      -20     
  Partials     1249     1249              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@omritoptix omritoptix merged commit 6926de8 into dymensionxyz:main Jan 12, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants