TypeAdapter generator #27
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gonzodepedro
force-pushed
the
typeadapter-generator
branch
from
33b5a4b to
99a1815
Compare
FlorianReimold
requested changes
Dec 11, 2023
rosidl_typesupport_protobuf_cpp/resource/idl__typeadapter_protobuf_cpp.hpp.em
Outdated
Show resolved
Hide resolved
|
Hm, GitHub now prompts me to resolve some merge conflicts between your fork and the master branch |
tfoote
force-pushed
the
typeadapter-generator
branch
from
803f03f to
52aaf8c
Compare
|
I rebased the changes onto the recent PRs. It's passing CI now. The copyright tests were failing due to being overly strict. I've ticketed to restore them at tfoote#11 |
gonzodepedro
force-pushed
the
typeadapter-generator
branch
from
52aaf8c to
8dd0fe1
Compare
Signed-off-by: Gonzo de Pedro <[email protected]>
Signed-off-by: Gonzo de Pedro <[email protected]>
Signed-off-by: Gonzo de Pedro <[email protected]>
Signed-off-by: Gonzo de Pedro <[email protected]>
Signed-off-by: Gonzo de Pedro <[email protected]>
Signed-off-by: Gonzo de Pedro <[email protected]>
Signed-off-by: Gonzo de Pedro <[email protected]>
Signed-off-by: Gonzo de Pedro <[email protected]>
Signed-off-by: Gonzo de Pedro <[email protected]>
Signed-off-by: Gonzo de Pedro <[email protected]>
Signed-off-by: Gonzo de Pedro <[email protected]>
Signed-off-by: Gonzalo de Pedro <[email protected]>
…ilure to match It's a false positive, but ament_copyright is moderately hard to extend. This should get it passing for the moment.
gonzodepedro
force-pushed
the
typeadapter-generator
branch
from
8dd0fe1 to
8bdb944
Compare
|
Attention: this branch has changed and been force pushed |
* Add a README.md for the typeadapter_protobuf
|
I am currently checking back with Eclipse if there are any processes to follow, as this contribution is very big and reviewing it line by line is probably not the best approach here. |
|
We will try to split this into multiple shorter and hopefully easier to review PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds automatic rclcpp::TypeAdapter generation for protobuf.
Note: Code is ready for review, documentation will come later.
Note: To be merged after #26