2 Protobuf Typeadapter Functionality #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 21, 2023
Closed
|
This is the primary implementation of type adaption from #27 The underlying commit from #30 is present and then there are three commits on top to review. Followed by the core implementation in commit: ccf9309 And then adding documentation in a8b58f4 And we found a bug in the visibility control when writing the above documentation. 45000b7 fixes the issue and then update the documentation to show the simplified approach. |
|
I merged #30. Can you merge the master to this branch or rebase it? there is also a conflict in init.py. |
Signed-off-by: Gonzo de Pedro <[email protected]>
* Add a README.md for the typeadapter_protobuf
Signed-off-by: Gonzalo de Pedro <[email protected]>
tfoote
force-pushed
the
2-protobuf-typeadapter-functionality
branch
from
45000b7 to
8711162
Compare
|
Hmm, not sure why that ended up with a conflict. It rebased cleanly on my checkout so I've updated the branch. |
FlorianReimold
approved these changes
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Second PR.
Depends on #30 being merged first.
This PR adds the ability to publish and subscribe using Protobuf objects, by automatically creating a Ros2 TypeAdapter.