Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating documentation and deprecating old APIs #105

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

erikbosch
Copy link
Contributor

This PR covers the following:

  • Trying to say something about the difference between v2 actuation and v1 "set target value" - that you cannot mix them. Off course - if we add some bridge between them we need to update the text
  • It says in text that the old APIs are deprecated. I think this is what we want right.
  • It makes sure that there are links to all documentation pages
  • It remove some references to Kuksa Server. As that tool has reached EoL we should in the long run remove all references.

Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.33%. Comparing base (a5314a6) to head (b76184c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #105      +/-   ##
==========================================
+ Coverage   59.23%   59.33%   +0.10%     
==========================================
  Files          33       33              
  Lines       16063    16067       +4     
==========================================
+ Hits         9515     9534      +19     
+ Misses       6548     6533      -15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

### Matching rules
# Wildcard Matching rules

*Note! This document applies to `sdv.databroker.v1` and `kuksa.val.v1` only!*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

@erikbosch erikbosch Nov 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That seems to be true. But we do not care about filter at all right? I thought we used a different approach there as the names root and filter seems to imply something else.

As it is implemented today we should better just have a single field and call it path, or?

In the description we say that root shall be a root branch, but in all test cases we using paths to a signal, like "test.datapoint1".

// List metadata of signals matching the request.
  //
  // Returns (GRPC error code):
  //   NOT_FOUND if the specified root branch does not exist.
  //   UNAUTHENTICATED if no credentials provided or credentials has expired
  //   INVALID_ARGUMENT if the provided path or wildcard is wrong.

So NOT_FOUND actually is returned if there are no matching entities. And most of the examples in https://github.com/eclipse-kuksa/kuksa-databroker/blob/main/doc/wildcard_matching.md has nothing to with a root branch.

So what shall we do - adapt Proto definition to implementation?

FYI @lukasmittag @argerus

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #106

We need to align what to do short-term (for next release) as well as long term for ListMetadata.

Doing as little as possible is one option - i.e. just adding a comment "Please do not use" in the *.proto files and documentation.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to add some text both explaining how it works today but also a remark that it may change

rafaeling
rafaeling previously approved these changes Nov 19, 2024
Copy link
Contributor

@rafaeling rafaeling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

doc/protocol.md Outdated
| ------------------------ |-----|-----|-----|-----|-----|-----|-----|-----|-----|
| gRPC (kuksa.val.v2) | Yes | Yes | Yes | No | No | No | Yes | No | Yes
| gRPC (kuksa.val.v1) *Deprecated!* | Yes | Yes | Yes | Yes | Yes | Yes | No | No | No
| gRPC (sdv.databroker.v1) *Deprecated!* | Yes | Yes | Yes | Yes | Yes | Yes | No | No | No
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sdv.databroker.v1 does not support getting or subscribing to a "target value". And (hence) when it comes to supporting actuation of VSS signals, it's behaviour is more in line with actuate and kuksa.val.v2.

rafaeling
rafaeling previously approved these changes Nov 25, 2024
@erikbosch erikbosch merged commit 8d9a3b2 into eclipse-kuksa:main Nov 25, 2024
23 checks passed
@erikbosch erikbosch deleted the erik_doc branch November 25, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants