Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generation to support migration to Jakarta #276

Merged
merged 7 commits into from
Apr 5, 2024
Merged

Generation to support migration to Jakarta #276

merged 7 commits into from
Apr 5, 2024

Conversation

Jad-el-khoury
Copy link
Contributor

@Jad-el-khoury Jad-el-khoury commented Mar 20, 2024 •
edited
Loading

Description

This PR depends on the Lyo PR eclipse-lyo/lyo#500 to produce working code.
It is demonstrated by the generated code in the OSLC OP RefImpl in this PR oslc-op/refimpl#198

Checklist

  • This PR adds an entry to the CHANGELOG. _See https://keepachangelog.com/en/1.0.0/ for instructions. Minor edits are exempt.
  • This PR expects some manual changes to the generated code. The needed changes are detailed in the CHANGELOG entry.
  • This PR was tested with at least one code generation, resulting in a working OSLC server.
  • This PR does NOT break the user block code

@jadelkhoury jadelkhoury mentioned this pull request Mar 20, 2024
Merged
@Jad-el-khoury Jad-el-khoury marked this pull request as draft March 20, 2024 23:12
@Jad-el-khoury Jad-el-khoury mentioned this pull request Mar 20, 2024
Merged
5 tasks
berezovskyi
berezovskyi approved these changes Mar 22, 2024
View reviewed changes
Copy link
Contributor

@berezovskyi berezovskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. See suggestion for Changelog improvement below.

CHANGELOG.md Outdated Show resolved Hide resolved
@berezovskyi berezovskyi marked this pull request as ready for review April 1, 2024 10:32
@Jad-el-khoury Jad-el-khoury merged commit dd0010d into master Apr 5, 2024
2 checks passed
@Jad-el-khoury Jad-el-khoury deleted the jakarta branch April 5, 2024 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@berezovskyi berezovskyi berezovskyi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jad-el-khoury @berezovskyi