-
Notifications
You must be signed in to change notification settings - Fork 729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a stub for java.lang.invoke.MethodHandleImpl #20570
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jenkins test sanity alinux jdk8,jdk11 |
java/lang/invoke/CustomizedLambdaFormTest.java failed.
|
jenkins test extended.openjdk amac jdk11 |
extended.openjdk PR https://openj9-jenkins.osuosl.org/job/PullRequest-OpenJ9/6429/ |
OpenJ9 JDK8 and JDK11 currently use OpenJ9 MethodHandles. Enabling jdk_bean in JDK8 and JDK11 triggers certain OpenJDK MethodHandles code paths. However, OpenJ9 MethodHandles are in use for JDK8 and JDK11, so OpenJDK MethodHandles paths shouldn't be activated. To address this, a MethodHandleImpl stub was added, used only with OpenJ9 MethodHandles, and not when OpenJDK MethodHandles are enabled. Related: eclipse-openj9#20531 Signed-off-by: Babneet Singh <[email protected]>
Added stubs for
|
|
jenkins compile amac jdk11 |
java/lang/invoke/CustomizedLambdaFormTest.java passed in a grinder. |
pshipton
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenJ9 JDK8 and JDK11 currently use OpenJ9 MethodHandles.
Enabling
jdk_bean
in JDK8 and JDK11 triggers certain OpenJDKMethodHandles code paths. However, OpenJ9 MethodHandles are in use
for JDK8 and JDK11, so OpenJDK MethodHandles paths shouldn't be
activated. To address this, a
MethodHandleImpl
stub was added,used only with OpenJ9 MethodHandles, and not when OpenJDK
MethodHandles are enabled.
Related: #20531