FindReplaceLogic.updateTarget should call endSession on current target #1846
Conversation
| @@ -588,12 +588,11 @@ public void updateTarget(IFindReplaceTarget newTarget, boolean canEditTarget) { | |||
| this.isTargetEditable = canEditTarget; | |||
|
|
|||
| if (this.target != newTarget) { | |||
| if (newTarget != null && newTarget instanceof IFindReplaceTargetExtension) | |||
| ((IFindReplaceTargetExtension) newTarget).endSession(); | |||
| if (this.target instanceof IFindReplaceTargetExtension) | |||
There was a problem hiding this comment.
We should end the session for the current target not for the new target.
|
|
||
| this.target = newTarget; | ||
| if (newTarget != null) | ||
| isTargetSupportingRegEx = newTarget instanceof IFindReplaceTargetExtension3; | ||
| isTargetSupportingRegEx = newTarget instanceof IFindReplaceTargetExtension3; |
There was a problem hiding this comment.
The null guard seems pointless.
|
FYI, I noticed that find in Oomph's setup editors was broken, often requiring me to close the editor to get it working again. I tested against EMF's editors (e.g., the Ecore editor) and it had the same problem. I finally tracked it down to this lifecycle problem. EMF add this control:
And when the editor no longer has focus, the session should end and the control should be removed:
|
Test Results 920 files 920 suites 38m 39s ⏱️ For more details on these failures, see this check. Results for commit 15169b5. |
|
Windows/Mac failures unrelated. |
No description provided.