Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ResourceInfoPage: wrap "location" #1895 #1929

Merged
merged 2 commits into from
Jun 6, 2024

Conversation

jukzi
Copy link
Contributor

@jukzi jukzi commented Jun 5, 2024

@jukzi jukzi requested a review from marcushoepfner June 5, 2024 08:22
@jukzi jukzi force-pushed the ResourceInfoPage branch from 037d07a to 55aaeac Compare June 5, 2024 08:25
@jukzi
Copy link
Contributor Author

jukzi commented Jun 5, 2024

@marcushoepfner this includes a revert due to regression

@jukzi jukzi linked an issue Jun 5, 2024 that may be closed by this pull request
@marcushoepfner
Copy link
Contributor

@marcushoepfner this includes a revert due to regression

Ok. Thanks @jukzi for fixing.
Sorry, I was not aware of this.

Copy link
Contributor

github-actions bot commented Jun 5, 2024

Test Results

 1 208 files  ±0   1 208 suites  ±0   1h 7m 17s ⏱️ + 2m 40s
 7 614 tests ±0   7 381 ✅  - 2  231 💤 ±0  2 ❌ +2 
15 996 runs  ±0  15 481 ✅  - 2  513 💤 ±0  2 ❌ +2 

For more details on these failures, see this check.

Results for commit a5f600d. ± Comparison against base commit 2ad6cac.

♻️ This comment has been updated with latest results.

@jukzi jukzi force-pushed the ResourceInfoPage branch 2 times, most recently from 311b0fe to 4d37569 Compare June 5, 2024 14:01
…eclipse-platform#1895

This reverts commit 8abe1b1.

The PreferenceDialog has a custom size calculation that tries to adapt
to the current page. That contradicts using the the former size

eclipse-platform#1895
@jukzi jukzi force-pushed the ResourceInfoPage branch from 4d37569 to a5f600d Compare June 6, 2024 09:47
@jukzi
Copy link
Contributor Author

jukzi commented Jun 6, 2024

ignoring unrelated random fail #195
Wrong job order: arrays first differed at element [0]; expected:<1. User Job(3604)> but was:<2. High Priority Job(3605)>

@jukzi jukzi merged commit 1f3c3e1 into eclipse-platform:master Jun 6, 2024
9 of 16 checks passed
@jukzi jukzi deleted the ResourceInfoPage branch June 6, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resource Properties Dialog to small to see buttons
3 participants